all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: phs <phs@lsv.fr>
To: 35710@debbugs.gnu.org
Subject: bug#35710: Acknowledgement (26.1; incomplete mapconcat description string)
Date: Tue, 14 May 2019 10:14:02 +0200	[thread overview]
Message-ID: <538e4215-0ff5-ea18-819f-a87c41a94e65@lsv.fr> (raw)
In-Reply-To: <handler.35710.B.155773799422638.ack@debbugs.gnu.org>

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

Thanks for the explanations, I never realized that concat was so
versatile (and I'm an emacs lover since 1983). Live and learn ...

Here is a suggested replacement for the documentation string (patch
attached). It produces

	Apply FUNCTION to each element of SEQUENCE, and concat the results as
strings.
	In between each pair of results, stick in SEPARATOR.  Thus, " " as
	SEPARATOR results in spaces between the values returned by FUNCTION.
	SEQUENCE may be a list, a vector, etc. see ‘mapcar’.
	SEPARATOR and all values returned by FUNCTION must be accepted by ‘concat’.

--phs

[-- Attachment #2: mapconcat-descr.patch --]
[-- Type: text/plain, Size: 709 bytes --]

diff --git a/src/fns.c b/src/fns.c
index c3202495da..f5e2584587 100644
--- a/src/fns.c
+++ b/src/fns.c
@@ -2668,7 +2668,8 @@ DEFUN ("mapconcat", Fmapconcat, Smapconcat, 3, 3, 0,
        doc: /* Apply FUNCTION to each element of SEQUENCE, and concat the results as strings.
 In between each pair of results, stick in SEPARATOR.  Thus, " " as
 SEPARATOR results in spaces between the values returned by FUNCTION.
-SEQUENCE may be a list, a vector, a bool-vector, or a string.  */)
+SEQUENCE may be a list, a vector, etc. see `mapcar'.
+SEPARATOR and all values returned by FUNCTION must be accepted by `concat'.  */)
   (Lisp_Object function, Lisp_Object sequence, Lisp_Object separator)
 {
   USE_SAFE_ALLOCA;

  parent reply	other threads:[~2019-05-14  8:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-13  8:43 bug#35710: 26.1; incomplete mapconcat description string phs
2019-05-13 12:02 ` Noam Postavsky
2019-05-13 14:14   ` Eli Zaretskii
     [not found] ` <handler.35710.B.155773799422638.ack@debbugs.gnu.org>
2019-05-14  8:14   ` phs [this message]
2019-06-07 13:02     ` bug#35710: Acknowledgement (26.1; incomplete mapconcat description string) Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538e4215-0ff5-ea18-819f-a87c41a94e65@lsv.fr \
    --to=phs@lsv.fr \
    --cc=35710@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.