build failure [Re: bug#17673: 24.4.50; trunk r117239 build failure on Windows]

build failure [Re: bug#17673: 24.4.50; trunk r117239 build failure on Windows]

[Stephen Berman]

On Tue, 03 Jun 2014 10:00:18 +0300 Eli Zaretskii <eliz@gnu.org> wrote:

>> Date: Mon, 02 Jun 2014 23:45:30 +0100
>> From: Andy Moreton <andrewjmoreton@gmail.com>
>> 
>> 
>> Building trunk r117239 with mingw32 fails:
>> 
>> gcc -std=gnu99  -c -mtune=pentium4   -I/c/emacs/mingw-devel/include 
>> -I/c/emacs/mingw-devel/src/xpm/3.5.1/libXpm-3.5.1-src/lib 
>> -DUSE_CRT_DLL=1 -I /c/emacs/src/emacs/trunk/obj-mingw32/../nt/inc 
>> -Demacs  -I. -I../../src -I../lib -I../../src/../lib -DHEAPSIZE=12 
>> -mtune=pentium4    -mms-bitfields 
>> -Ic:/emacs/mingw-devel/include/librsvg-2.0 
>> -Ic:/emacs/mingw-devel/include/glib-2.0 
>> -Ic:/emacs/mingw-devel/lib/glib-2.0/include 
>> -Ic:/emacs/mingw-devel/include/gdk-pixbuf-2.0 
>> -Ic:/emacs/mingw-devel/include/cairo 
>> -Ic:/emacs/mingw-devel/include/libpng16 
>> -Ic:/emacs/mingw-devel/include/pixman-1 
>> -Ic:/emacs/mingw-devel/include/libxml2            -MMD -MF deps/menu.d 
>> -MP -Ic:/emacs/mingw-devel/include 
>> -Ic:/emacs/mingw-devel/include/p11-kit-1      -O0 -g3  ../../src/menu.c
>> In file included from ../../src/menu.h:25:0,
>>                   from ../../src/menu.c:52:
>> ../../src/../lwlib/lwlib.h:24:27: fatal error: X11/Intrinsic.h: No such 
>> file or directory
>> compilation terminated.
>> make[1]: *** [menu.o] Error 1
>
> Should be fixed now.

I get the same error bootstrapping GNU/Linux from trunk bzr 117248,
i.e. after your fix.  My system:

x86_64-suse-linux-gnu, GTK+ Version 3.10.4
Windowing system distributor `The X.Org Foundation', version 11.0.11403901
System Description:	openSUSE 13.1 (Bottle) (x86_64)

Configured using:
 `configure --without-toolkit-scroll-bars CFLAGS=-g3'

Steve Berman

Re: build failure [Re: bug#17673: 24.4.50; trunk r117239 build failure on Windows]

[Eli Zaretskii]

> From: Stephen Berman <stephen.berman@gmx.net>
> Date: Tue, 03 Jun 2014 17:11:48 +0200
> 
> >> In file included from ../../src/menu.h:25:0,
> >>                   from ../../src/menu.c:52:
> >> ../../src/../lwlib/lwlib.h:24:27: fatal error: X11/Intrinsic.h: No such 
> >> file or directory
> >> compilation terminated.
> >> make[1]: *** [menu.o] Error 1
> >
> > Should be fixed now.
> 
> I get the same error bootstrapping GNU/Linux from trunk bzr 117248,
> i.e. after your fix.

I fixed it only for MS-Windows.

> My system:
> 
> x86_64-suse-linux-gnu, GTK+ Version 3.10.4
> Windowing system distributor `The X.Org Foundation', version 11.0.11403901
> System Description:	openSUSE 13.1 (Bottle) (x86_64)
> 
> Configured using:
>  `configure --without-toolkit-scroll-bars CFLAGS=-g3'

That would mean you don't have X11 headers on that system installed?
How's that possible?

Re: build failure [Re: bug#17673: 24.4.50; trunk r117239 build failure on Windows]

[Eli Zaretskii]

> Date: Tue, 03 Jun 2014 19:04:36 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
> 
> > From: Stephen Berman <stephen.berman@gmx.net>
> > Date: Tue, 03 Jun 2014 17:11:48 +0200
> > 
> > >> In file included from ../../src/menu.h:25:0,
> > >>                   from ../../src/menu.c:52:
> > >> ../../src/../lwlib/lwlib.h:24:27: fatal error: X11/Intrinsic.h: No such 
> > >> file or directory
> > >> compilation terminated.
> > >> make[1]: *** [menu.o] Error 1
> > >
> > > Should be fixed now.
> > 
> > I get the same error bootstrapping GNU/Linux from trunk bzr 117248,
> > i.e. after your fix.
> 
> I fixed it only for MS-Windows.
> 
> > My system:
> > 
> > x86_64-suse-linux-gnu, GTK+ Version 3.10.4
> > Windowing system distributor `The X.Org Foundation', version 11.0.11403901
> > System Description:	openSUSE 13.1 (Bottle) (x86_64)
> > 
> > Configured using:
> >  `configure --without-toolkit-scroll-bars CFLAGS=-g3'
> 
> That would mean you don't have X11 headers on that system installed?
> How's that possible?

FWIW, I've just compiled the current trunk on a x86_64 Trisquel
GNU/Linux with GTK-2.0, and saw no warnings or errors.

Re: build failure [Re: bug#17673: 24.4.50; trunk r117239 build failure on Windows]

[Stephen Berman]

On Tue, 03 Jun 2014 19:13:16 +0300 Eli Zaretskii <eliz@gnu.org> wrote:

>> Date: Tue, 03 Jun 2014 19:04:36 +0300
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: emacs-devel@gnu.org
>> 
>> > From: Stephen Berman <stephen.berman@gmx.net>
>> > Date: Tue, 03 Jun 2014 17:11:48 +0200
>> > 
>> > >> In file included from ../../src/menu.h:25:0,
>> > >>                   from ../../src/menu.c:52:
>> > >> ../../src/../lwlib/lwlib.h:24:27: fatal error: X11/Intrinsic.h: No such 
>> > >> file or directory
>> > >> compilation terminated.
>> > >> make[1]: *** [menu.o] Error 1
>> > >
>> > > Should be fixed now.
>> > 
>> > I get the same error bootstrapping GNU/Linux from trunk bzr 117248,
>> > i.e. after your fix.
>> 
>> I fixed it only for MS-Windows.
>> 
>> > My system:
>> > 
>> > x86_64-suse-linux-gnu, GTK+ Version 3.10.4
>> > Windowing system distributor `The X.Org Foundation', version 11.0.11403901
>> > System Description:	openSUSE 13.1 (Bottle) (x86_64)
>> > 
>> > Configured using:
>> >  `configure --without-toolkit-scroll-bars CFLAGS=-g3'
>> 
>> That would mean you don't have X11 headers on that system installed?
>> How's that possible?

> FWIW, I've just compiled the current trunk on a x86_64 Trisquel
> GNU/Linux with GTK-2.0, and saw no warnings or errors.

I do have some X11 headers but not Intrinsic.h.  Apparently this isn't
needed in the current openSUSE.  Anyway, till today I haven't seen this
error and haven't otherwise had an X11-related problem building Emacs.

Steve Berman

Re: build failure [Re: bug#17673: 24.4.50; trunk r117239 build failure on Windows]

[Eli Zaretskii]

> From: Stephen Berman <stephen.berman@gmx.net>
> Cc: emacs-devel@gnu.org
> Date: Tue, 03 Jun 2014 18:41:54 +0200
> 
> I do have some X11 headers but not Intrinsic.h.  Apparently this isn't
> needed in the current openSUSE.

Perhaps Intrinsic.h requires an installation of some extra development
package?

> Anyway, till today I haven't seen this error and haven't otherwise
> had an X11-related problem building Emacs.

Indeed, up until revision 117239, lwlib.h was only included when
USE_X_TOOLKIT was defined, not for USE_GTK.  Perhaps we should keep
the separate definition of enum button_type and the widget_value
typedef for USE_GTK as well, as we had before that revision?

Re: build failure [Re: bug#17673: 24.4.50; trunk r117239 build failure on Windows]

[Eli Zaretskii]

> Date: Tue, 03 Jun 2014 20:02:37 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
> 
> > Anyway, till today I haven't seen this error and haven't otherwise
> > had an X11-related problem building Emacs.
> 
> Indeed, up until revision 117239, lwlib.h was only included when
> USE_X_TOOLKIT was defined, not for USE_GTK.  Perhaps we should keep
> the separate definition of enum button_type and the widget_value
> typedef for USE_GTK as well, as we had before that revision?

lwlib.h is now also included by gtkutil.h, so it too will have to be
changed, if we want to avoid including lwlib.h in GTK builds.

Re: build failure [Re: bug#17673: 24.4.50; trunk r117239 build failure on Windows]

[Dmitry Antipov]

On 06/03/2014 09:13 PM, Eli Zaretskii wrote:

>> Date: Tue, 03 Jun 2014 20:02:37 +0300
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: emacs-devel@gnu.org
>>
>>> Anyway, till today I haven't seen this error and haven't otherwise
>>> had an X11-related problem building Emacs.
>>
>> Indeed, up until revision 117239, lwlib.h was only included when
>> USE_X_TOOLKIT was defined, not for USE_GTK.  Perhaps we should keep
>> the separate definition of enum button_type and the widget_value
>> typedef for USE_GTK as well, as we had before that revision?
>
> lwlib.h is now also included by gtkutil.h, so it too will have to be
> changed, if we want to avoid including lwlib.h in GTK builds.

I tried --without-x, --with-x-toolkit=no, --with-x-toolkit=lucid,
--with-x-toolkit=motif and default (which means GTK3), and didn't
see any issues.

Dmitry

Re: build failure [Re: bug#17673: 24.4.50; trunk r117239 build failure on Windows]

[Dmitry Antipov]

On 06/03/2014 09:02 PM, Eli Zaretskii wrote:

>> From: Stephen Berman <stephen.berman@gmx.net>
>> Cc: emacs-devel@gnu.org
>> Date: Tue, 03 Jun 2014 18:41:54 +0200
>>
>> I do have some X11 headers but not Intrinsic.h.  Apparently this isn't
>> needed in the current openSUSE.
>
> Perhaps Intrinsic.h requires an installation of some extra development
> package?

Most probably you have gtk[23]-devel but no libXt-devel package installed.

Dmitry

Re: build failure [Re: bug#17673: 24.4.50; trunk r117239 build failure on Windows]

[Glenn Morris]

Dmitry Antipov wrote:

> Most probably you have gtk[23]-devel but no libXt-devel package installed.

Note this old comment in configure.ac:

dnl Don't set this for GTK.  A lot of tests below assumes Xt when
dnl USE_X_TOOLKIT is set.
            USE_X_TOOLKIT=none ;;

So it was intentional that libXt-devel has not been required in gtk
builds till now.

Re: build failure [Re: bug#17673: 24.4.50; trunk r117239 build failure on Windows]

[Dmitry Antipov]

On 06/03/2014 09:52 PM, Glenn Morris wrote:

> Note this old comment in configure.ac:
>
> dnl Don't set this for GTK.  A lot of tests below assumes Xt when
> dnl USE_X_TOOLKIT is set.
>              USE_X_TOOLKIT=none ;;
>
> So it was intentional that libXt-devel has not been required in gtk
> builds till now.

So, utterly crappy lwlib interface forces us to choose one from:

1) require libXt-devel even for GTK build and have lwlib stubs
    in src/menu.h (for HAVE_NTGUI), or

2) do not require libXt-devel for GTK build, but have even more
    lwlib stubs in src/gtkutil.[ch] (as it was before r117239).

What about an idea to really port lwlib enough to avoid stubs at all?

Dmitry

Re: build failure [Re: bug#17673: 24.4.50; trunk r117239 build failure on Windows]

[Stephen Berman]

On Tue, 03 Jun 2014 21:29:50 +0400 Dmitry Antipov <dmantipov@yandex.ru> wrote:

> On 06/03/2014 09:02 PM, Eli Zaretskii wrote:
>
>>> From: Stephen Berman <stephen.berman@gmx.net>
>>> Cc: emacs-devel@gnu.org
>>> Date: Tue, 03 Jun 2014 18:41:54 +0200
>>>
>>> I do have some X11 headers but not Intrinsic.h.  Apparently this isn't
>>> needed in the current openSUSE.
>>
>> Perhaps Intrinsic.h requires an installation of some extra development
>> package?
>
> Most probably you have gtk[23]-devel but no libXt-devel package installed.

That is correct.  It's no problem to install it (I assume), though I
haven't needed it till now; but I'll wait till the dust settles, in case
the requirement is reverted for Gtk+ builds.

Steve Berman

Re: build failure [Re: bug#17673: 24.4.50; trunk r117239 build failure on Windows]

[Paul Eggert]

On 06/03/2014 11:51 AM, Stephen Berman wrote:
> I'll wait till the dust settles, in case
> the requirement is reverted for Gtk+ builds.

I tried to fix this in trunk bzr 117250, so that you shouldn't need 
libXt-devel installed any more.  The new approach was having problems in 
--with-ns builds too.  This latest change affects the Windows builds; I 
hope I caught all the problems there, though I can't easily test Windows.

Re: build failure [Re: bug#17673: 24.4.50; trunk r117239 build failure on Windows]

[Eli Zaretskii]

> Date: Tue, 03 Jun 2014 13:02:11 -0700
> From: Paul Eggert <eggert@cs.ucla.edu>
> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
> 
> On 06/03/2014 11:51 AM, Stephen Berman wrote:
> > I'll wait till the dust settles, in case
> > the requirement is reverted for Gtk+ builds.
> 
> I tried to fix this in trunk bzr 117250, so that you shouldn't need 
> libXt-devel installed any more.  The new approach was having problems in 
> --with-ns builds too.  This latest change affects the Windows builds; I 
> hope I caught all the problems there, though I can't easily test Windows.

You did allright for Windows, but then broke it all by the sysselect.h
changes.  I fixed that in r117252.

Re: build failure [Re: bug#17673: 24.4.50; trunk r117239 build failure on Windows]

[Stephen Berman]

On Tue, 03 Jun 2014 13:02:11 -0700 Paul Eggert <eggert@cs.ucla.edu> wrote:

> On 06/03/2014 11:51 AM, Stephen Berman wrote:
>> I'll wait till the dust settles, in case
>> the requirement is reverted for Gtk+ builds.
>
> I tried to fix this in trunk bzr 117250, so that you shouldn't need
> libXt-devel installed any more.

Works for me; thanks.

Steve Berman