* Re: [Emacs-diffs] trunk r117169: * src/bytecode.c (FETCH) [BYTE_CODE_SAFE]: Check the bytecode wasn't [not found] <E1WpR6o-0007KI-H8@vcs.savannah.gnu.org> @ 2014-05-27 23:55 ` Daniel Colascione 2014-05-28 0:19 ` Stefan Monnier 0 siblings, 1 reply; 2+ messages in thread From: Daniel Colascione @ 2014-05-27 23:55 UTC (permalink / raw) To: Stefan Monnier, emacs-devel [-- Attachment #1: Type: text/plain, Size: 523 bytes --] On 05/27/2014 04:48 PM, Stefan Monnier wrote: > ------------------------------------------------------------ > revno: 117169 > revision-id: monnier@iro.umontreal.ca-20140527234835-nad9g3elkd8bep4b > parent: eliz@gnu.org-20140527173117-et72fjq7lazj50mj > committer: Stefan Monnier <monnier@iro.umontreal.ca> > branch nick: trunk > timestamp: Tue 2014-05-27 19:48:35 -0400 > message: > * src/bytecode.c (FETCH) [BYTE_CODE_SAFE]: Check the bytecode wasn't > relocated from under us. When does that happen? [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 884 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Emacs-diffs] trunk r117169: * src/bytecode.c (FETCH) [BYTE_CODE_SAFE]: Check the bytecode wasn't 2014-05-27 23:55 ` [Emacs-diffs] trunk r117169: * src/bytecode.c (FETCH) [BYTE_CODE_SAFE]: Check the bytecode wasn't Daniel Colascione @ 2014-05-28 0:19 ` Stefan Monnier 0 siblings, 0 replies; 2+ messages in thread From: Stefan Monnier @ 2014-05-28 0:19 UTC (permalink / raw) To: Daniel Colascione; +Cc: emacs-devel > When does that happen? The GC relocates strings to compact the string blocks, so it is very common for strings to be relocated. So it requires special code to update pointers into the middle of strings, such as the "pc" in bytecode activation frames. This debug code was the one that let me finally track down the source of a bug we had in the implementation of the "new handler bytecodes" (the bug was in the handling of variables lives across setjmp/longjmp). Stefan ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-28 0:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1WpR6o-0007KI-H8@vcs.savannah.gnu.org>
2014-05-27 23:55 ` [Emacs-diffs] trunk r117169: * src/bytecode.c (FETCH) [BYTE_CODE_SAFE]: Check the bytecode wasn't Daniel Colascione
2014-05-28 0:19 ` Stefan Monnier
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.