all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH] Add missed "provide" function to subr.el
@ 2020-03-16 20:01 Serghei Iakovlev
  2020-03-16 20:11 ` Stefan Monnier
  0 siblings, 1 reply; 4+ messages in thread
From: Serghei Iakovlev @ 2020-03-16 20:01 UTC (permalink / raw)
  To: GNU Emacs Developers

[-- Attachment #1: Type: text/plain, Size: 127 bytes --]

Hello,

There is a small patch for ‘subr.el’ to add missed `provide'
function call (see attachment).

-- 
Serghei


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: subr.el.patch --]
[-- Type: text/x-patch; name="subr.el.patch", Size: 298 bytes --]

diff --git a/lisp/subr.el b/lisp/subr.el
index a744cfddfd..cf7d78a442 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -5771,4 +5771,5 @@ 'flatten-list
 (defconst regexp-unmatchable "\\`a\\`"
   "Standard regexp guaranteed not to match any string at all.")
 
+(provide 'subr)
 ;;; subr.el ends here

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Add missed "provide" function to subr.el
  2020-03-16 20:01 [PATCH] Add missed "provide" function to subr.el Serghei Iakovlev
@ 2020-03-16 20:11 ` Stefan Monnier
  2020-03-16 20:22   ` Serghei Iakovlev
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2020-03-16 20:11 UTC (permalink / raw)
  To: Serghei Iakovlev; +Cc: GNU Emacs Developers

> There is a small patch for ‘subr.el’ to add missed `provide'
> function call (see attachment).

Why bother?  subr.el is presumably always included.


        Stefan




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Add missed "provide" function to subr.el
  2020-03-16 20:11 ` Stefan Monnier
@ 2020-03-16 20:22   ` Serghei Iakovlev
  2020-03-17  1:03     ` Philipp Stephani
  0 siblings, 1 reply; 4+ messages in thread
From: Serghei Iakovlev @ 2020-03-16 20:22 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: GNU Emacs Developers

Well, maybe I got something wrong.  However, when I require it
directly:

(require 'subr)

I see flychek error:

Loaded file <path omitted>/lisp/subr.elc failed to provide
feature ‘subr’.

On 3/16/20 10:11 PM, Stefan Monnier wrote:
> 
>> There is a small patch for ‘subr.el’ to add missed `provide'
>> function call (see attachment).
> 
> Why bother?  subr.el is presumably always included.
> 
> 
>         Stefan
> 

-- 
Serghei




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Add missed "provide" function to subr.el
  2020-03-16 20:22   ` Serghei Iakovlev
@ 2020-03-17  1:03     ` Philipp Stephani
  0 siblings, 0 replies; 4+ messages in thread
From: Philipp Stephani @ 2020-03-17  1:03 UTC (permalink / raw)
  To: Serghei Iakovlev; +Cc: Stefan Monnier, GNU Emacs Developers

Am Mo., 16. März 2020 um 21:22 Uhr schrieb Serghei Iakovlev
<egrep@protonmail.ch>:
>
> Well, maybe I got something wrong.  However, when I require it
> directly:
>
> (require 'subr)
>
> I see flychek error:
>
> Loaded file <path omitted>/lisp/subr.elc failed to provide
> feature ‘subr’.

Just remove that `require' form. It's never needed, since subr is
always preloaded.

>
> On 3/16/20 10:11 PM, Stefan Monnier wrote:
> >
> >> There is a small patch for ‘subr.el’ to add missed `provide'
> >> function call (see attachment).
> >
> > Why bother?  subr.el is presumably always included.
> >
> >
> >         Stefan
> >
>
> --
> Serghei
>
>



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-03-17  1:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-16 20:01 [PATCH] Add missed "provide" function to subr.el Serghei Iakovlev
2020-03-16 20:11 ` Stefan Monnier
2020-03-16 20:22   ` Serghei Iakovlev
2020-03-17  1:03     ` Philipp Stephani

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.