From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build Date: Sat, 24 May 2014 14:14:10 -0400 Message-ID: <5380E172.8090004@cornell.edu> References: <53764FD9.8090600@cornell.edu> <53766FBC.1000601@cornell.edu> <5377F335.2080609@cornell.edu> <831tvremfz.fsf@gnu.org> <5378C404.8050405@cornell.edu> <83wqdjceah.fsf@gnu.org> <53790BAB.3020909@cornell.edu> <837g5hd8cf.fsf@gnu.org> <537A5AB4.8070602@cornell.edu> <538092B6.9000807@cornell.edu> <83sinzjpt0.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1400955336 26046 80.91.229.3 (24 May 2014 18:15:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 24 May 2014 18:15:36 +0000 (UTC) Cc: 17510@debbugs.gnu.org, dmantipov@yandex.ru To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 24 20:15:24 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WoGTc-000198-3G for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 May 2014 20:15:24 +0200 Original-Received: from localhost ([::1]:48996 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WoGTb-0005Xt-AH for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 May 2014 14:15:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WoGTR-0005Wu-Ad for bug-gnu-emacs@gnu.org; Sat, 24 May 2014 14:15:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WoGTH-0003n2-HG for bug-gnu-emacs@gnu.org; Sat, 24 May 2014 14:15:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60421) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WoGTH-0003mg-Dv for bug-gnu-emacs@gnu.org; Sat, 24 May 2014 14:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WoGTG-0003t7-PC for bug-gnu-emacs@gnu.org; Sat, 24 May 2014 14:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 May 2014 18:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17510-submit@debbugs.gnu.org id=B17510.140095524714847 (code B ref 17510); Sat, 24 May 2014 18:15:02 +0000 Original-Received: (at 17510) by debbugs.gnu.org; 24 May 2014 18:14:07 +0000 Original-Received: from localhost ([127.0.0.1]:59298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoGSN-0003rO-8L for submit@debbugs.gnu.org; Sat, 24 May 2014 14:14:07 -0400 Original-Received: from limerock01.mail.cornell.edu ([128.84.12.99]:41846) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoGSJ-0003qU-TW for 17510@debbugs.gnu.org; Sat, 24 May 2014 14:14:04 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id s4OIDvvf017286; Sat, 24 May 2014 14:13:58 -0400 Original-Received: from [192.168.1.3] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id s4OIDu02015984 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 24 May 2014 14:13:57 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 In-Reply-To: <83sinzjpt0.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:89458 Archived-At: On 5/24/2014 8:59 AM, Eli Zaretskii wrote: > This looks OK to me, but I wonder: is it really correct not to free > w32_id_name at all? And if that is correct, why only on Cygwin? I would say it's harmless not to free w32_id_name. It's malloc'd once and never changed. But I agree that it's harmless also on native Windows. > Does the Cygwin-w32 build also use a single dpyinfo object, like the > native Windows build? Yes > If so, perhaps we need not free this in both > these builds. IOW, I think your suggested change is OK for the > emacs-24 branch, but on the trunk I'd suggest to remove the xfree line > altogether. OK, I've made the change on the emacs-24 branch as revision 117147. After this has been merged to the trunk, I'll remove the xfree line. I'm not closing the bug yet because I forgot to retest my change after revision 117146 was made, and the latter is causing a problem with emacsclient (at least on Cygwin-w32). I need to make sure that this isn't related to my change. Ken