From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.bugs Subject: bug#17486: 24.4.50; set-face-font problem on OSX Date: Mon, 19 May 2014 07:38:51 +0400 Message-ID: <53797CCB.6000204@yandex.ru> References: <2C3533D7-8966-48CC-A63E-E7C363E5F429@swipnet.se> <537613B2.10803@swipnet.se> <53762664.9040700@yandex.ru> <4D37DE1B-52D9-4AD1-AC85-8E17C1887110@swipnet.se> <537632E0.1010403@yandex.ru> <18DD744E-FCBD-4613-A4F0-E74404B662F3@swipnet.se> <53784884.6040704@yandex.ru> <40E1EC60-3BC6-491D-ACF2-13DFF19B03A2@swipnet.se> <5378DD31.8090604@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------020001050904020802060109" X-Trace: ger.gmane.org 1400470829 24548 80.91.229.3 (19 May 2014 03:40:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 19 May 2014 03:40:29 +0000 (UTC) Cc: 17486@debbugs.gnu.org, Christian Lynbech To: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 19 05:40:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WmER3-0006pd-Ha for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 May 2014 05:40:21 +0200 Original-Received: from localhost ([::1]:45409 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmER3-00030w-1d for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 May 2014 23:40:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmEQt-00030p-0b for bug-gnu-emacs@gnu.org; Sun, 18 May 2014 23:40:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmEQm-0000kV-03 for bug-gnu-emacs@gnu.org; Sun, 18 May 2014 23:40:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53714) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmEQl-0000ie-Ql for bug-gnu-emacs@gnu.org; Sun, 18 May 2014 23:40:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WmEQl-0006vj-7a for bug-gnu-emacs@gnu.org; Sun, 18 May 2014 23:40:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Antipov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 May 2014 03:40:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17486 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17486-submit@debbugs.gnu.org id=B17486.140047074426525 (code B ref 17486); Mon, 19 May 2014 03:40:03 +0000 Original-Received: (at 17486) by debbugs.gnu.org; 19 May 2014 03:39:04 +0000 Original-Received: from localhost ([127.0.0.1]:52591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WmEPn-0006tk-5f for submit@debbugs.gnu.org; Sun, 18 May 2014 23:39:03 -0400 Original-Received: from forward2l.mail.yandex.net ([84.201.143.145]:52313) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WmEPj-0006t7-TA for 17486@debbugs.gnu.org; Sun, 18 May 2014 23:39:01 -0400 Original-Received: from smtp7.mail.yandex.net (smtp7.mail.yandex.net [77.88.61.55]) by forward2l.mail.yandex.net (Yandex) with ESMTP id 307121AC0FCE; Mon, 19 May 2014 07:38:53 +0400 (MSK) Original-Received: from smtp7.mail.yandex.net (localhost [127.0.0.1]) by smtp7.mail.yandex.net (Yandex) with ESMTP id B80041580058; Mon, 19 May 2014 07:38:52 +0400 (MSK) Original-Received: from unknown (unknown [37.139.80.10]) by smtp7.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 9YYxQKtPWX-cqgm6VU0; Mon, 19 May 2014 07:38:52 +0400 (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client certificate not present) X-Yandex-Uniq: be3952ee-e2fc-4c7c-99eb-3080f87c685e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1400470732; bh=bkYDUeyKI42m8Rp9zbUDeAYYUN4OBkHvx0PQ6VdI/WM=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type; b=fwujSHUESHhT+lJmvXzET0kgDVJturMzeytUD5x3zkodNl0ERLYaA09mV8wolcusy i2xYwzAIx83iUAuo/VZuK3ydlU2eWHmqziEoLwEvjJ8TAZuujzPHvRa6d7YGusFaRh RsWd8ial9Z2LK+9ftelaw5IZe6Xyk6D4dI61M7Ko= Authentication-Results: smtp7.mail.yandex.net; dkim=pass header.i=@yandex.ru User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:89223 Archived-At: This is a multi-part message in MIME format. --------------020001050904020802060109 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable On 05/18/2014 10:33 PM, Jan Dj=E4rv wrote: >> Hm... so font_matching_entity sometimes returns [#] inste= ad of #. >> Something may be wrong with font cache or with font driver-specific ma= tch routine. > > How can code (driver-specific) that has not changed suddenly become wro= ng? It may return something which doesn't match font cache data structures an= y more because the latter was changed (mostly to avoid glitches in compact_font_= caches). There was a slight confusion between font_list_entities (which operates on vectors of font entities) and font_matching_entity (which should opera= te on font entities). Hopefully the fix is almost obvious. Dmitry --------------020001050904020802060109 Content-Type: text/x-patch; name="bug17486_proposal.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="bug17486_proposal.patch" === modified file 'src/font.c' --- src/font.c 2014-04-05 19:30:36 +0000 +++ src/font.c 2014-05-19 03:23:51 +0000 @@ -2803,7 +2803,7 @@ ASET (work, FONT_TYPE_INDEX, driver_list->driver->type); entity = assoc_no_quit (work, XCDR (cache)); if (CONSP (entity)) - entity = XCDR (entity); + entity = AREF (XCDR (entity), 0); else { entity = driver_list->driver->match (f, work); --------------020001050904020802060109--