From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 1b71c995da: Avoid binding mouse-1 in xref when mouse-1 doesn't follow links Date: Fri, 29 Apr 2022 19:16:11 +0300 Message-ID: <5371c7d3-2677-f89c-ed4c-05a4f664c9be@yandex.ru> References: <165123369667.6415.4605821518748112960@vcs2.savannah.gnu.org> <20220429120137.0F053C06322@vcs2.savannah.gnu.org> <87fslwdo88.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7969"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 29 18:27:42 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nkTT4-0001v3-Am for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 18:27:42 +0200 Original-Received: from localhost ([::1]:53686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkTT3-0004QL-Ay for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 12:27:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55564) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkTI1-0002Om-Lq for emacs-devel@gnu.org; Fri, 29 Apr 2022 12:16:17 -0400 Original-Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:54172) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nkTHz-00068D-Dq for emacs-devel@gnu.org; Fri, 29 Apr 2022 12:16:17 -0400 Original-Received: by mail-wm1-x32d.google.com with SMTP id p189so4893788wmp.3 for ; Fri, 29 Apr 2022 09:16:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=NtkpZlCDqoYMpB/qRY2OXJSNSBt+gtkbrUIlKRJTYYo=; b=LTLX7BhEvrpP1HoesJm7NbPOU2lLQCnPY46O2fybB6pV0oshPX68HP7eZfbJUL3I4g 2I1TF03TUKprHT5D1cm57itywY0iRgklIVYGDVKs71NcFD3lKeQok41u0nfk35gBvAz+ RT5lGyX9QfCJGQM3i1I0qxv1GI0/Vk18IC2HKuazOFnEul9wyf3BtKpZO8XroqrK1mKc 7sYlzFoAfa0g3qRMy0+6Gj/qNAJtKVNHcmalIDKyBBODZvHqldbIA5FX97jYIC6Q4TcZ VGzKupUv+AJGIOmrmWxjCPnzWZLEbj66GlcYabVSgNnVKjZDy3Hr1VSX4yD94MOistXU tmQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=NtkpZlCDqoYMpB/qRY2OXJSNSBt+gtkbrUIlKRJTYYo=; b=ZRebJIA4+hkRZgrxdvbFIxWqiJ76ZCWVdhbn03dZQdiX+MmAf6H6BDmY0rF7842n6X r22SZFZi0OPxbTCUwWXNGW8QpNWm5su6V4WXSvmYhLEObC8MwA7G4o0whdIAFODOMuZE zLGh1psn083tJIV5CgBsXkiM7tMUZJYcyNCizTHjN7Rehqg584nvQf9vpkHxVf2/kggz DsZ8f2xed/XYUUaUyOBfA3fM9UWC/5DsGiDnxmTSChjVLgf++LSpIf1KZL1hyPGxrBtO ZGT4NBZwlFOm3bxOQ4Ks8Xh3W49rYKTQEa0C3M/0TByvB6HOBsuu9UjugeTCWOAPZ2dP 1EgA== X-Gm-Message-State: AOAM533W+g0OU32PvLF4b1xOMR5GltyItLmB0XIgFR6+uALyfEZpf6sB Db1prdG9zTsKRA0CmiNz3+8= X-Google-Smtp-Source: ABdhPJwIS5dv/lybOP7rDBlOuqSyDI0uqEzFqLlNj9hsw6broR1h2vvlOBMJAGks49wEqcmeYnOm5Q== X-Received: by 2002:a05:600c:34ce:b0:392:9cf:4e25 with SMTP id d14-20020a05600c34ce00b0039209cf4e25mr3849732wmq.193.1651248973661; Fri, 29 Apr 2022 09:16:13 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id r14-20020adfa14e000000b0020aeab110b8sm2945670wrr.74.2022.04.29.09.16.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Apr 2022 09:16:13 -0700 (PDT) Content-Language: en-US In-Reply-To: <87fslwdo88.fsf@gnus.org> Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=raaahh@gmail.com; helo=mail-wm1-x32d.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289006 Archived-At: On 29.04.2022 16:16, Lars Ingebrigtsen wrote: > Stefan Monnier writes: > >> Hmm... this won't adjust if `mouse-1-click-follows-link` is changed >> later on. Why do we need this `mouse-1` binding? > Dmitry seems to like the two different actions (which only differ in > whether the other buffer is selected or not). I'd be fine with removing > the mouse-1 binding. TBH, I don't really mind either way. I don't use the mouse in these buffers (and rarely do that at all in Emacs). I proposed a slightly different change in the past (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35353#77), but if other similar modes (like Grep and Occur) behave differently and consistently between themselves, it probably makes sense to follow their example.