all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: BONSOFT Jaroslaw Czekalski <jaroslaw.czekalski@bonsoft.pl>
To: 17432@debbugs.gnu.org
Subject: bug#17432: 24.4.50; minibuffer history forgets the first entry
Date: Wed, 07 May 2014 10:56:08 +0200	[thread overview]
Message-ID: <5369F528.9020004@bonsoft.pl> (raw)

[-- Attachment #1: Type: text/html, Size: 5489 bytes --]

[-- Attachment #2: history_1_00.patch --]
[-- Type: text/plain, Size: 1061 bytes --]

=== modified file 'src/ChangeLog'
--- src/ChangeLog	2014-05-06 21:13:37 +0000
+++ src/ChangeLog	2014-05-07 08:54:40 +0000
@@ -1,3 +1,8 @@
+2014-05-07  Jarek Czekalski  <jarekczek@poczta.onet.pl>
+
+	Fix initialization of minibuffer history variable (Bug#xxxxx).
+	* minibuf.c (read_minibuf): Initialize histval to Qnil if unbound.
+
 2014-05-06  Paul Eggert  <eggert@cs.ucla.edu>
 
 	* image.c: Do not use libpng if HAVE_NS, as NS does its own thing.

=== modified file 'src/minibuf.c'
--- src/minibuf.c	2014-03-21 17:04:50 +0000
+++ src/minibuf.c	2014-05-07 08:54:21 +0000
@@ -708,8 +708,10 @@
       /* If variable is unbound, make it nil.  */
 
       histval = find_symbol_value (Vminibuffer_history_variable);
-      if (EQ (histval, Qunbound))
-	Fset (Vminibuffer_history_variable, Qnil);
+      if (EQ (histval, Qunbound)) {
+        Fset (Vminibuffer_history_variable, Qnil);
+        histval = Qnil;
+      }
 
       /* The value of the history variable must be a cons or nil.  Other
 	 values are unacceptable.  We silently ignore these values.  */


             reply	other threads:[~2014-05-07  8:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-07  8:56 BONSOFT Jaroslaw Czekalski [this message]
2014-05-07 18:27 ` bug#17432: 24.4.50; minibuffer history forgets the first entry Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5369F528.9020004@bonsoft.pl \
    --to=jaroslaw.czekalski@bonsoft.pl \
    --cc=17432@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.