From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Kifer Newsgroups: gmane.emacs.bugs Subject: bug#17388: 24.4.50; REGRESSION: Ediff - 1) wrong face, 2) incorrect diffing Date: Sat, 03 May 2014 11:57:23 -0400 Message-ID: <536511E3.1000905@stonybrook.edu> References: <> <<87wqe43t55.fsf@rosalinde.fritz.box>> <> <<111c9271-6a23-426e-adb2-ff5520c02806@default>> <<83a9az1hok.fsf@gnu.org>> <8613042fc3be4f9995e33e38d4f079f0@HUBCAS1.cs.stonybrook.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1399132710 20281 80.91.229.3 (3 May 2014 15:58:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 3 May 2014 15:58:30 +0000 (UTC) Cc: "17388@debbugs.gnu.org" <17388@debbugs.gnu.org> To: Drew Adams , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 03 17:58:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WgcKT-0005oH-41 for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 May 2014 17:58:21 +0200 Original-Received: from localhost ([::1]:49346 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgcKS-0000TU-Q5 for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 May 2014 11:58:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgcKI-0000TE-J8 for bug-gnu-emacs@gnu.org; Sat, 03 May 2014 11:58:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgcKB-00005r-2R for bug-gnu-emacs@gnu.org; Sat, 03 May 2014 11:58:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60750) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgcKA-00005n-Un for bug-gnu-emacs@gnu.org; Sat, 03 May 2014 11:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WgcKA-0005Nx-AE for bug-gnu-emacs@gnu.org; Sat, 03 May 2014 11:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Kifer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 May 2014 15:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17388 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17388-submit@debbugs.gnu.org id=B17388.139913265320662 (code B ref 17388); Sat, 03 May 2014 15:58:02 +0000 Original-Received: (at 17388) by debbugs.gnu.org; 3 May 2014 15:57:33 +0000 Original-Received: from localhost ([127.0.0.1]:49868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgcJg-0005NB-JD for submit@debbugs.gnu.org; Sat, 03 May 2014 11:57:32 -0400 Original-Received: from mail-qc0-f180.google.com ([209.85.216.180]:40825) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgcJe-0005Mx-EU for 17388@debbugs.gnu.org; Sat, 03 May 2014 11:57:30 -0400 Original-Received: by mail-qc0-f180.google.com with SMTP id i17so5344457qcy.39 for <17388@debbugs.gnu.org>; Sat, 03 May 2014 08:57:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=+YcMJpltJFcfx/SF6muFk49W3PaVlRhDP4jsduFUugQ=; b=lwTnCV7IJ5BDtKb8y+BRwlXIr4lGag0xHViDY/kSUG70p0gNF6Mu61M58A2A21vsuV A+JE8FRkilUFg5wrgtZRFO7Zm0wc6zclf5WUM3vCoT3EYU9B1QvAG5CU2cIEaQhVwNyU /vXBk0D3WWhXkibmVEut2TNvCLOCgkgVx6F5dD8ryIrQ/WtNhxfpad0VDgzVa2LtoU3Z quweVUlJXKrBaQjraqEfbCsgjB0zk1D8kQb7W3b3ctaUTcrJ+lSayLEqPLzdmrEwoBXk 6UR3dZZhf7Twsq7sJcyJAxD+7VOyzVtKg8oWBbpscFuEJsExQKQXmbWvuiiidldZf1BR c0UQ== X-Gm-Message-State: ALoCoQnEnFCB1VtHoZT8TMBFfJKS/2KQmCeSnOZYr06HKXPzdqm9C60hpt3Ztq7AW3uoGHP/WDRk X-Received: by 10.224.103.197 with SMTP id l5mr31726346qao.69.1399132644694; Sat, 03 May 2014 08:57:24 -0700 (PDT) Original-Received: from [192.168.1.106] (ool-18bf44a9.dyn.optonline.net. [24.191.68.169]) by mx.google.com with ESMTPSA id l10sm5124266qav.13.2014.05.03.08.57.23 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 03 May 2014 08:57:24 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 In-Reply-To: <8613042fc3be4f9995e33e38d4f079f0@HUBCAS1.cs.stonybrook.edu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88592 Archived-At:
On 05/03/2014 10:01 AM, Drew Adams wrote:
There should be EITHER, (a) as previously, NO fine diffs shown for
other than the current diff OR (b) CORRECT (helpful) fine diffs
shown for the non-current diffs.

Ediff's "fine diffs" are word-granular.  That is, Ediff breaks each
line into "words", then passes the result to the Diff program for
comparisoon, and reflects the results with different faces.  AFAIR,
this has always been that way.

OK, so you are saying that Emacs has silently changed to (b) from (a),
and the way it does fine diffs corresponds to what is shown.  So be it.

Ediff never showed fine diffs for any region but the current one.

--

       --- michael

 


I see both of these problematic highlightings on GNU/Linux builds from
both the trunk (bzr 117042) and the emacs-24 branch (bzr 117049).

I can confirm that too, but (a) I don't think the 2nd issue
constitutes a "problem" (see above), and (b) it is definitely not a
"REGRESSION", because older Emacsen behaved the same wrt fine diffs
inside a line.

It is a change in behavior wrt older Emacsen, which do not show fine
diffs within the non-current diffs.  Regression or improvement - we
can have different opinions.  (BTW, I see nothing in NEWS about this
behavior change.)

But more importantly, "REGRESSION" in the subject line is for the bug
report, and #1 is the more serious part: removing diff highlighting
from part of a diff gives the impression that that unhighlighted text
is not different.