From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Matthias Dahl Newsgroups: gmane.emacs.bugs Subject: bug#16434: bug#16694: bugs #16694/#16378: Patches Date: Mon, 28 Apr 2014 20:36:26 +0200 Message-ID: <535E9FAA.9050508@binary-island.eu> References: <52F601AE.5040309@binary-island.eu> <83wqfiz36v.fsf@gnu.org> <5331D45B.7090704@binary-island.eu> <5335920F.4030008@binary-island.eu> <533C26F3.4040600@binary-island.eu> <83lhvk8b6x.fsf@gnu.org> <83a9bz92h2.fsf@gnu.org> <534517A5.1070306@binary-island.eu> <53492567.4090303@binary-island.eu> <83zjjqsjn7.fsf@gnu.org> <5349546A.4040500@binary-island.eu> <83zjjc82nq.fsf@gnu.org> <53580259.7010508@binary-island.eu> <535CBE43.7000803@binary-island.eu> <83a9b5o1e7.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1398710250 16280 80.91.229.3 (28 Apr 2014 18:37:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Apr 2014 18:37:30 +0000 (UTC) Cc: gundaetiapo@gmail.com, 16434@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 28 20:37:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WeqQc-0000Rq-JB for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Apr 2014 20:37:22 +0200 Original-Received: from localhost ([::1]:45431 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WeqQc-0006zK-4U for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Apr 2014 14:37:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WeqQQ-0006yr-Es for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2014 14:37:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WeqQI-0007Ld-QB for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2014 14:37:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WeqQI-0007LF-JE for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2014 14:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WeqQH-0004SB-PQ for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2014 14:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Matthias Dahl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Apr 2014 18:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16434 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16434-submit@debbugs.gnu.org id=B16434.139871019717078 (code B ref 16434); Mon, 28 Apr 2014 18:37:01 +0000 Original-Received: (at 16434) by debbugs.gnu.org; 28 Apr 2014 18:36:37 +0000 Original-Received: from localhost ([127.0.0.1]:44121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WeqPs-0004RN-Of for submit@debbugs.gnu.org; Mon, 28 Apr 2014 14:36:37 -0400 Original-Received: from hemera.binary-island.eu ([97.107.138.233]:41937) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WeqPq-0004R8-B1 for 16434@debbugs.gnu.org; Mon, 28 Apr 2014 14:36:35 -0400 Original-Received: from [10.0.0.20] (95-90-41-152-dynip.superkabel.de [95.90.41.152]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by hemera.binary-island.eu (Postfix) with ESMTPSA id 573683C12B; Mon, 28 Apr 2014 14:36:48 -0400 (EDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 In-Reply-To: <83a9b5o1e7.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88375 Archived-At: On 28/04/14 18:38, Eli Zaretskii wrote: > Unfortunately, it doesn't fix the problem. It looks like the problem > is that when make-face-x-resource-internal is called near the end of > face-spec-recalc, inhibit-x-resources is already set non-nil, and so > make-face-x-resource-internal does nothing. Ah, that little bit of information I missed. In that case, everything's actually working as intended. If you start Emacs and force it to ignore X resources, it does so entirely and as expected... even more so in 24.4 now. Programmatically "setting" an X resource behind the scenes and expecting it to work even though that very system has been asked to do nothing, is bound to cause trouble. Don't get me wrong, it is still a bug, nevertheless... only it is imho debatable what the root cause really is in this case. The fact that the X resource is not being applied (despite inhibit-x-resources == t) or that the toolbar coloring is changed this way and expected to work at all times, even if inhibit-x-resources == t. > Don't you see the same problem on X if you set > emacs.tool-bar.attributeBackground in the X resources? That would > allow you to try the change on your system. If that would work, I would consider it a bug. If an X resource was applied even though I started Emacs w/ -Q or otherwise set inhibit-... that would very much be a bug. At least imho that is. > Btw, in the future, you don't need to submit 2 identical patches, just > one to the release branch is enough: it will get merged onto the trunk > soon enough after being committed to the branch. Ah, Ok. I'll keep that in mind. Thanks... I'll have a look at this issue sometime later this week or weekend and see what is going on exactly and if there is a way to fix this without actually implementing any exceptions into make-face-x-... or anything alike. Naturally, if someone else wants to take a stab at it who knows more about all those tightly intervened and sneaky parts of the code than I do (that one shouldn't be hard :P), I absolutely won't mind. :-) So long, Matthias -- Dipl.-Inf. (FH) Matthias Dahl | Software Engineer | binary-island.eu services: custom software [desktop, mobile, web], server administration