bug#17334: 24.3; Crash in cmdproxy.exe

bug#17334: 24.3; Crash in cmdproxy.exe

[Sohail Somani]

There is a "bug" in cmdproxy.exe which should never happen, but does
anyway. In make_absolute, there is the following code:

   strncpy(dir, path, p - path);
   dir[p - path] = '\0';

If p-path > sizeof(dir), a buffer overrun occurs.

I came across this problem because I accidentally used ':' as a
separator when constructing the PATH variable in Emacs.

Thanks,

Sohail

bug#17334: 24.3; Crash in cmdproxy.exe

[Eli Zaretskii]

> Date: Wed, 23 Apr 2014 23:58:57 -0400
> From: Sohail Somani <sohail@taggedtype.net>
> 
> There is a "bug" in cmdproxy.exe which should never happen, but does
> anyway. In make_absolute, there is the following code:
> 
>    strncpy(dir, path, p - path);
>    dir[p - path] = '\0';
> 
> If p-path > sizeof(dir), a buffer overrun occurs.
> 
> I came across this problem because I accidentally used ':' as a
> separator when constructing the PATH variable in Emacs.

Thanks, this is now fixed for Emacs 24.4 (revision 117021 on the
emacs-24 branch).