From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Matthias Dahl Newsgroups: gmane.emacs.bugs Subject: bug#16434: bug#16694: bugs #16694/#16378: Patches Date: Wed, 23 Apr 2014 20:11:37 +0200 Message-ID: <53580259.7010508@binary-island.eu> References: <52F601AE.5040309@binary-island.eu> <87k3bj40nu.fsf@cougar.home.aneadesign.com> <83wqfiz36v.fsf@gnu.org> <5331D45B.7090704@binary-island.eu> <5335920F.4030008@binary-island.eu> <533C26F3.4040600@binary-island.eu> <83lhvk8b6x.fsf@gnu.org> <83a9bz92h2.fsf@gnu.org> <534517A5.1070306@binary-island.eu> <53492567.4090303@binary-island.eu> <83zjjqsjn7.fsf@gnu.org> <5349546A.4040500@binary-island.eu> <83zjjc82nq.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1398276748 24936 80.91.229.3 (23 Apr 2014 18:12:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Apr 2014 18:12:28 +0000 (UTC) Cc: gundaetiapo@gmail.com, 16434@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 23 20:12:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wd1ec-0005VM-TO for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Apr 2014 20:12:19 +0200 Original-Received: from localhost ([::1]:34158 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wd1ec-0003r9-A5 for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Apr 2014 14:12:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wd1eS-0003fp-U7 for bug-gnu-emacs@gnu.org; Wed, 23 Apr 2014 14:12:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wd1eM-0006Lg-SD for bug-gnu-emacs@gnu.org; Wed, 23 Apr 2014 14:12:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48258) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wd1eM-0006Lc-OE for bug-gnu-emacs@gnu.org; Wed, 23 Apr 2014 14:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Wd1eL-0005Du-TC for bug-gnu-emacs@gnu.org; Wed, 23 Apr 2014 14:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Matthias Dahl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Apr 2014 18:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16434 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16434-submit@debbugs.gnu.org id=B16434.139827670320045 (code B ref 16434); Wed, 23 Apr 2014 18:12:01 +0000 Original-Received: (at 16434) by debbugs.gnu.org; 23 Apr 2014 18:11:43 +0000 Original-Received: from localhost ([127.0.0.1]:56415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wd1e2-0005DE-Mo for submit@debbugs.gnu.org; Wed, 23 Apr 2014 14:11:43 -0400 Original-Received: from hemera.binary-island.eu ([97.107.138.233]:58489) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wd1e0-0005D6-EO for 16434@debbugs.gnu.org; Wed, 23 Apr 2014 14:11:41 -0400 Original-Received: from [10.0.0.20] (95-90-43-88-dynip.superkabel.de [95.90.43.88]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by hemera.binary-island.eu (Postfix) with ESMTPSA id A1FA83C51D; Wed, 23 Apr 2014 14:11:52 -0400 (EDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 In-Reply-To: <83zjjc82nq.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88263 Archived-At: Hello Eli... If no one else has taken care of this by the weekend, I'll happily take a look then. Right now, I'm really short on time. I'm very sorry. :( I apologize for the short answer in advance... You are right. I looked over the 24.3 sources and also based on what you described, the priority order needs fixing. If I remember correctly though, this is very delicate and simply switching positions will cause other bad side effects. :( > I don't understand this logic: resources are a kind of customization, > so they should override the default face spec, not the other way > around. Am I missing something? When I initially set out to fix those bugs, I researched and, if I do remember correctly, found an old thread where this was discussed and I believe it was settled that Emacs defaults should always prevail. But in hindsight, this makes no sense and I might have gotten things wrong. I would like to remind you that the original and fundamental changes to those functions where done by someone else. IMHO, they cleared a few things up in contrast to 24.3... but introduced several bugs-- like the ones I fixed and the one you are seeing now... unfortunately. > This change was done because --reverse-video didn't work, If you refer to my patches and explicitly moving the X resources stuff at the beginning of face-spec-recalc: Those changes were done because themes were broken. :) The changes I made for the reverse-video stuff should not have caused this side effects and actually brought everything more in line w/ 24.3... if anything else. Like I said, if no one has taken care of this by the weekend, I will gladly have a look and try to fix this as well. Sorry I couldn't be of more help at this time, though. So long, Matthias -- Dipl.-Inf. (FH) Matthias Dahl | Software Engineer | binary-island.eu services: custom software [desktop, mobile, web], server administration