From: Matthias Dahl <matthias.dahl@binary-island.eu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gundaetiapo@gmail.com, 16434@debbugs.gnu.org
Subject: bug#16434: bug#16694: bugs #16694/#16378: Patches
Date: Wed, 23 Apr 2014 20:11:37 +0200 [thread overview]
Message-ID: <53580259.7010508@binary-island.eu> (raw)
In-Reply-To: <83zjjc82nq.fsf@gnu.org>
Hello Eli...
If no one else has taken care of this by the weekend, I'll happily take
a look then. Right now, I'm really short on time. I'm very sorry. :(
I apologize for the short answer in advance...
You are right. I looked over the 24.3 sources and also based on what you
described, the priority order needs fixing. If I remember correctly
though, this is very delicate and simply switching positions will cause
other bad side effects. :(
> I don't understand this logic: resources are a kind of customization,
> so they should override the default face spec, not the other way
> around. Am I missing something?
When I initially set out to fix those bugs, I researched and, if I do
remember correctly, found an old thread where this was discussed and I
believe it was settled that Emacs defaults should always prevail. But in
hindsight, this makes no sense and I might have gotten things wrong.
I would like to remind you that the original and fundamental changes to
those functions where done by someone else. IMHO, they cleared a few
things up in contrast to 24.3... but introduced several bugs-- like the
ones I fixed and the one you are seeing now... unfortunately.
> This change was done because --reverse-video didn't work,
If you refer to my patches and explicitly moving the X resources stuff
at the beginning of face-spec-recalc: Those changes were done because
themes were broken. :) The changes I made for the reverse-video stuff
should not have caused this side effects and actually brought everything
more in line w/ 24.3... if anything else.
Like I said, if no one has taken care of this by the weekend, I will
gladly have a look and try to fix this as well. Sorry I couldn't be of
more help at this time, though.
So long,
Matthias
--
Dipl.-Inf. (FH) Matthias Dahl | Software Engineer | binary-island.eu
services: custom software [desktop, mobile, web], server administration
next prev parent reply other threads:[~2014-04-23 18:11 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-08 10:06 bug#16694: Regression by commit 115663 (bzr): Theme face attributes no longer take precedence over X resources Matthias Dahl
2014-02-12 22:21 ` Glenn Morris
2014-02-14 19:17 ` Matthias Dahl
2014-02-20 18:27 ` Eli Zaretskii
2014-02-20 21:47 ` Stefan Monnier
2014-02-21 9:07 ` Eli Zaretskii
2014-02-21 17:36 ` Stefan Monnier
2014-02-23 16:46 ` Matthias Dahl
2014-02-23 17:18 ` Eli Zaretskii
2014-02-24 19:29 ` Matthias Dahl
2014-02-26 15:49 ` bug#16378: Empty face settings ignored (was bug#16694: Regression by commit 115663 (bzr): Theme face attributes no longer take precedence over X resources) Stefan Monnier
2014-02-27 19:05 ` Matthias Dahl
2014-03-02 14:26 ` Matthias Dahl
2014-03-02 16:56 ` Eli Zaretskii
2014-03-05 16:14 ` bug#16694: bugs #16694/#16378: Patches Matthias Dahl
2014-03-16 19:13 ` bug#16378: " Matthias Dahl
2014-03-17 14:33 ` Eli Zaretskii
2014-03-21 18:05 ` bug#16694: " Barry OReilly
2014-03-22 8:30 ` Eli Zaretskii
2014-03-23 17:04 ` Matthias Dahl
2014-03-24 23:42 ` Barry OReilly
2014-03-24 23:49 ` Clemens Schüller
2014-03-25 14:17 ` Barry OReilly
2014-03-25 15:51 ` Eli Zaretskii
2014-03-25 16:17 ` Barry OReilly
2014-03-25 19:09 ` Matthias Dahl
2014-03-26 23:49 ` Barry OReilly
2014-03-27 14:22 ` Stefan Monnier
2014-03-28 14:59 ` Barry OReilly
2014-03-28 15:15 ` bug#16434: " Matthias Dahl
2014-04-01 17:15 ` Barry OReilly
2014-04-01 18:17 ` Matthias Dahl
2014-04-02 15:04 ` Matthias Dahl
2014-04-02 16:47 ` Barry OReilly
2014-04-02 18:36 ` bug#16434: " Matthias Dahl
2014-04-02 19:34 ` Barry OReilly
2014-04-05 7:52 ` bug#16378: " Eli Zaretskii
2014-04-05 15:48 ` Stefan Monnier
2014-04-05 16:15 ` Eli Zaretskii
2014-04-07 9:58 ` bug#16434: " Matthias Dahl
2014-04-09 9:49 ` Matthias Dahl
2014-04-12 11:37 ` bug#16378: " Matthias Dahl
2014-04-12 14:32 ` Eli Zaretskii
2014-04-12 14:57 ` Matthias Dahl
2014-04-23 15:51 ` bug#16434: " Eli Zaretskii
2014-04-23 18:11 ` Matthias Dahl [this message]
2014-04-24 0:36 ` Stefan Monnier
2014-04-27 8:22 ` Matthias Dahl
2014-04-28 16:38 ` Eli Zaretskii
2014-04-28 18:36 ` Matthias Dahl
2014-04-28 19:18 ` Eli Zaretskii
2014-04-30 18:34 ` Matthias Dahl
2014-03-26 15:30 ` Eli Zaretskii
2014-03-26 16:03 ` Glenn Morris
2014-03-26 13:39 ` bug#16694: Strange background color problem in gentoo Linux Barry OReilly
2014-03-26 15:11 ` Joakim Tjernlund
2014-03-26 16:49 ` Barry OReilly
2014-03-26 18:12 ` bug#16694: Strange background color problem in gentoo GNU/Linux Joakim Tjernlund
2014-03-26 15:58 ` bug#16694: Strange background color problem in gentoo Linux Clemens Schüller
2014-03-26 18:18 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53580259.7010508@binary-island.eu \
--to=matthias.dahl@binary-island.eu \
--cc=16434@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=gundaetiapo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.