From: "Andreas Röhler" <andreas.roehler@easy-emacs.de>
To: 17320@debbugs.gnu.org
Subject: bug#17320: 24.3.90.1[pretest]; bug-sourcing design-flaw
Date: Wed, 23 Apr 2014 09:43:38 +0200 [thread overview]
Message-ID: <53576F2A.5000609@easy-emacs.de> (raw)
When looking for bug #17247
noticed the following
lisp.el, line 374:
;; When comparing point against pos, we want to consider that if
;; point was right after the end of the function, it's still
;; considered as "in that function".
;; E.g. `eval-defun' from right after the last close-paren.
(unless (bolp)
(skip-chars-forward " \t")
(if (looking-at "\\s<\\|\n")
(forward-line 1)))
;;;;;;;;;
A core function should not do that kind of provisions.
Employing forward-line, point might end up at the beginning of valid code, not at the end.
Thus beginning and end of functions are in risk being mixed.
Suggest to drop that and let `eval-defun' etc. make provisions at their needs.
Thanks,
Andreas
GNU Emacs 24.3.90.1 (i686-pc-linux-gnu, GTK+ Version 2.24.10) of 2014-04-21
next reply other threads:[~2014-04-23 7:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 7:43 Andreas Röhler [this message]
2014-04-29 15:47 ` bug#17320: 24.3.90.1[pretest]; bug-sourcing design-flaw Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53576F2A.5000609@easy-emacs.de \
--to=andreas.roehler@easy-emacs.de \
--cc=17320@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.