From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Jan D." Newsgroups: gmane.emacs.devel Subject: Re: Hourglass only for X-windows? Date: Fri, 11 Mar 2005 18:25:26 +0100 Message-ID: <534dd629871884654f6c43846c34db9a@swipnet.se> References: <000701c51cf5$d269ee10$0200a8c0@sedrcw11488> <01c51d0b$Blat.v2.4$215fcf20@zahav.net.il> <003201c51d2b$5c57e2f0$0200a8c0@sedrcw11488> <01c51d4f$Blat.v2.4$8840d7e0@zahav.net.il> <007801c51dae$4674c560$0200a8c0@sedrcw11488> <01c51dea$Blat.v2.4$254bbb00@zahav.net.il> <001901c51df4$1a9400a0$0200a8c0@sedrcw11488> <00b301c525c9$9cf3ba40$0200a8c0@sedrcw11488> <01c5263e$Blat.v2.4$65b1b4e0@zahav.net.il> <4231A0BE.1070704@gnu.org> <00cc01c52653$f3ce6ce0$0200a8c0@sedrcw11488> <01c52655$Blat.v2.4$b47b9200@zahav.net.il> <00ee01c52659$a01c9620$0200a8c0@sedrcw11488> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (Apple Message framework v619.2) Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1110562685 21478 80.91.229.2 (11 Mar 2005 17:38:05 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 11 Mar 2005 17:38:05 +0000 (UTC) Cc: hunterd42@comcast.net, Eli Zaretskii , jasonr@gnu.org, kobayays@otsukakj.co.jp, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 11 18:38:04 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1D9nzu-0007Qa-Vr for ged-emacs-devel@m.gmane.org; Fri, 11 Mar 2005 18:32:27 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D9oF2-0008Mp-8W for ged-emacs-devel@m.gmane.org; Fri, 11 Mar 2005 12:48:04 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D9oE5-00084s-A4 for emacs-devel@gnu.org; Fri, 11 Mar 2005 12:47:05 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D9oE1-00082r-03 for emacs-devel@gnu.org; Fri, 11 Mar 2005 12:47:02 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D9oE0-00081Q-Kf for emacs-devel@gnu.org; Fri, 11 Mar 2005 12:47:00 -0500 Original-Received: from [195.54.107.70] (helo=mxfep01.bredband.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1D9ntf-0001MV-2p; Fri, 11 Mar 2005 12:25:59 -0500 Original-Received: from coolsville.localdomain ([83.226.180.210] [83.226.180.210]) by mxfep01.bredband.com with ESMTP id <20050311172557.DGIW28780.mxfep01.bredband.com@coolsville.localdomain>; Fri, 11 Mar 2005 18:25:57 +0100 In-Reply-To: <00ee01c52659$a01c9620$0200a8c0@sedrcw11488> Original-To: "Lennart Borgman" X-Mailer: Apple Mail (2.619.2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34483 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34483 >> This would require to have some configury stuff that would detect >> whether HAVE_HOURGLASS should be defined or not. Since Windows >> doesn't run the usual configure script (and neither does the DOS >> port), adding such a define will require more hacking in these ports. >> Especially since writing a test for this feature is not so easy even >> for those platforms which do support hourglass (e.g., think about >> Emacs configured with --without-x). >> >> So please don't do that. Please replace >> >> #ifdef HAVE_X_WINDOWS >> >> with >> >> #if defined(HAVE_X_WINDOWS) || defined(HAVE_NTGUI) > > There is a lot of them. I understand your concern. However we do not > have to > do anything difficult to use HAVE_HOURGLASS. After taking a look at > the code > I believe HAVE_HOURGLASS should go into src\config.in. There is > already an > #ifdef HAVE_X_WINDOWS and I suggest putting something like this after > that > define: > > /* This is for the hourglass code in various files. */ > #if defined(HAVE_X_WINDOWS) || defined(HAVE_NTGUI) > #define HAVE_HOURGLASS > #endif > > IMO it will be more readable and if you want to add hourglass code for > other > systems some day it is easier. But the w32 port does not expand config.in to config.h AFAIK, so this does nothing when building on w32. Jan D.