From: Gregory Heytings <gregory@heytings.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 57499@debbugs.gnu.org
Subject: bug#57499: Documentation bug in the docstring of set-face-attribute?
Date: Wed, 31 Aug 2022 12:04:03 +0000 [thread overview]
Message-ID: <534c9018d2f372cd7462@heytings.org> (raw)
In-Reply-To: <831qswu0p4.fsf@gnu.org>
>> The docstring of set-face-attribute says:
>>
>> "As an exception, to reset the value of some attribute to `unspecified'
>> in a way that overrides the non-`unspecified' value defined by the
>> face's spec in `defface', for new frames, you must explicitly call this
>> function with FRAME set to t and the attribute's value set to
>> `unspecified'; just using FRAME of nil will not affect new frames in
>> this case."
>>
>> Not only is that sentence hard to parse, it also seems wrong.
>>
>> Can someone come up with a scenario in which a call
>>
>> (set-face-attribute 'some-face nil :some-attribute 'unspecified)
>>
>> only affects existing frames? In my testing it affects all frames
>> (existing and future ones), and that's also what the code seems to do:
>> set-face-attribute sets where to 0 when frame is nil, and calls
>> internal-set-lisp-face-attribute with frame = 0, which according to the
>> docstring of internal-set-lisp-face-attribute "means change the face on
>> all frames, and change the default for new frames".
>
> This was discussed in bug#54156. Are there any new findings or
> considerations that would require to reopen that discussion?
>
As far as I can tell, there are, but if you disagree, feel free to close
the bug. Bug#54156 starts with someone telling that
(set-face-attribute 'some-face nil :background nil)
did not have an effect in new frames. To which you replied:
>
> The correct way to do [that] is this:
>
> (set-face-attribute 'some-face nil :background 'unspecified)
> (set-face-attribute 'some-face t :background 'unspecified)
>
> That is, one must explicitly call set-face-attribute with FRAME = t (as
> well as nil), and pass 'unspecified' (NOT nil!) as the value.
>
and you later added that the call with frame = t is "a special trick to
override defface with 'unspecified'".
It seems however that the call with frame = t is unnecessary, or at least,
I could not come up with a scenario in which the first call does not also
affect new frames.
next prev parent reply other threads:[~2022-08-31 12:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 8:14 bug#57499: Documentation bug in the docstring of set-face-attribute? Gregory Heytings
2022-08-31 8:17 ` Gregory Heytings
2022-08-31 11:11 ` Eli Zaretskii
2022-08-31 12:04 ` Gregory Heytings [this message]
2022-08-31 12:39 ` Eli Zaretskii
2022-08-31 12:53 ` Gregory Heytings
2022-08-31 13:06 ` Eli Zaretskii
2022-08-31 13:43 ` Gregory Heytings
2022-08-31 16:11 ` Eli Zaretskii
2022-08-31 18:33 ` Gregory Heytings
2022-08-31 19:13 ` Eli Zaretskii
2022-08-31 19:33 ` Gregory Heytings
2022-08-31 19:49 ` Eli Zaretskii
2022-08-31 21:13 ` Gregory Heytings
2022-09-01 7:04 ` Eli Zaretskii
2022-09-01 8:25 ` Gregory Heytings
2022-09-01 8:44 ` Eli Zaretskii
2022-09-01 9:02 ` Gregory Heytings
2022-09-01 11:33 ` Eli Zaretskii
2022-09-01 11:56 ` Gregory Heytings
2022-09-01 12:08 ` Eli Zaretskii
2022-09-01 13:15 ` Gregory Heytings
2022-09-01 14:56 ` Eli Zaretskii
2022-09-01 17:07 ` Gregory Heytings
2022-09-01 18:24 ` Eli Zaretskii
2022-09-01 19:35 ` Gregory Heytings
2022-09-02 16:00 ` Eli Zaretskii
2022-09-02 20:48 ` Gregory Heytings
2022-09-03 6:00 ` Eli Zaretskii
2022-09-03 6:43 ` Gregory Heytings
2022-09-03 1:26 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534c9018d2f372cd7462@heytings.org \
--to=gregory@heytings.org \
--cc=57499@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.