From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#17172: 24.3.50; Timeouts when pasting from mouse Date: Tue, 15 Apr 2014 13:19:31 -0700 Organization: UCLA Computer Science Department Message-ID: <534D9453.9040700@cs.ucla.edu> References: <87eh1fsved.fsf@linaro.org> <534CE79A.3030600@cs.ucla.edu> <534D0749.3060404@swipnet.se> <534D57EA.1000503@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1397593232 24688 80.91.229.3 (15 Apr 2014 20:20:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Apr 2014 20:20:32 +0000 (UTC) Cc: Alex =?UTF-8?Q?Benn=C3=A9e?= , 17172@debbugs.gnu.org To: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 15 22:20:25 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wa9qB-0001F8-JO for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Apr 2014 22:20:23 +0200 Original-Received: from localhost ([::1]:51615 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wa9qB-00016M-5v for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Apr 2014 16:20:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wa9q0-0000vA-Rl for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2014 16:20:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wa9pq-0008KZ-TA for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2014 16:20:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wa9pq-0008K3-Og for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2014 16:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Wa9pq-00049S-1E for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2014 16:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Apr 2014 20:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17172 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17172-submit@debbugs.gnu.org id=B17172.139759319115932 (code B ref 17172); Tue, 15 Apr 2014 20:20:01 +0000 Original-Received: (at 17172) by debbugs.gnu.org; 15 Apr 2014 20:19:51 +0000 Original-Received: from localhost ([127.0.0.1]:49175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wa9pe-00048t-UL for submit@debbugs.gnu.org; Tue, 15 Apr 2014 16:19:51 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:40757) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wa9pd-00048e-7z for 17172@debbugs.gnu.org; Tue, 15 Apr 2014 16:19:50 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 6C6AA39E8014; Tue, 15 Apr 2014 13:19:43 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id znjV8DDKYKm1; Tue, 15 Apr 2014 13:19:34 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id BAC6539E8012; Tue, 15 Apr 2014 13:19:34 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88041 Archived-At: Jan Djärv wrote: > That can't happen, all masks are initialized with FD_ZERO. True, but after that they can be reused in some cases and it's not immediately obvious that they are guaranteed to be properly reinitialized for every call to xg_select. > If we passed masks with garbage in them to pselect we would get EINVAL back. Not if the garbage's 1 bits happen to correspond to open file descriptors. > In that case, process.c does not inspect the masks, so this change fixes nothing. Although it doesn't inspect the masks right away, in some cases it reuses a mask later. The code is reasonably tricky here. > you just used it as a means to get untested code into the emacs-24 branch Hmm, well, that's a bit unfair as I did test it, but as you're sure the change doesn't fix any user-visible bugs I reverted it.