bug#17128: 24.3.50; `newline-and-indent' should not indent the current line

bug#17128: 24.3.50; `newline-and-indent' should not indent the current line

[Dmitry Gutov]

Tags: patch

There's `reindent-then-newline-and-indent' for that.

In GNU Emacs 24.3.50.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.8.6)
 of 2014-03-23 on axl
Repository revision: 116830 dgutov@yandex.ru-20140322084330-wrwcmwjdbe3mu712
Windowing system distributor `The X.Org Foundation', version 11.0.11405000
System Description:	Ubuntu 13.10


=== modified file 'lisp/simple.el'
--- lisp/simple.el	2014-03-25 23:30:08 +0000
+++ lisp/simple.el	2014-03-28 06:15:14 +0000
@@ -611,7 +611,7 @@
 column specified by the function `current-left-margin'."
   (interactive "*")
   (delete-horizontal-space t)
-  (newline nil t)
+  (newline)
   (indent-according-to-mode))
 
 (defun reindent-then-newline-and-indent ()

bug#17128: 24.3.50; `newline-and-indent' should not indent the current line

[Stefan Monnier]

> There's `reindent-then-newline-and-indent' for that.

Agreed.


        Stefan

bug#17128: 24.3.50; `newline-and-indent' should not indent the current line

[Dmitry Gutov]

On 28.03.2014 16:17, Stefan Monnier wrote:
>> There's `reindent-then-newline-and-indent' for that.
>
> Agreed.

Hmm, I'm not sure about the patch, though.

If `newline-and-indent' shouldn't reindent the current line [even when 
electric-indent-mode is enabled] because there's 
`reindent-then-newline-and-indent', then `newline' likewise probably 
shouldn't (re)indent either of the lines because of the existence of the 
former two functions.

In that case, my suggestion to separate the electric indent on RET from 
indenting after newline wouldn't exactly work.

Could we define new commands in electric-mode, and bind them when it's on?

Something like `electric-maybe-indent-then-newline' and 
`electric-maybe-reindent-then-newline-and-indent'.

bug#17128: 24.3.50; `newline-and-indent' should not indent the current line

[Stefan Monnier]

> Could we define new commands in electric-mode, and bind them when it's on?
> Something like `electric-maybe-indent-then-newline' and
> `electric-maybe-reindent-then-newline-and-indent'.

That's an option, yes.  Alan might like it.


        Stefan

bug#17128: 24.3.50; `newline-and-indent' should not indent the current line

[Dmitry Gutov]

On 01.04.2014 23:08, Stefan Monnier wrote:

> That's an option, yes.  Alan might like it.

Too bad that discussion is going very slowly.

I'm pulling this patch because it also breaks 
`electric-pair-open-newline-between-pairs'.