From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: Tabs Date: Thu, 10 Oct 2019 11:15:55 +0200 Message-ID: <53365bd1-96e0-feb1-362d-1d8b6a35450f@gmx.at> References: <20191008085604.tjtxm6ndyuluocbs@Ergus> <83lftvy4s6.fsf@gnu.org> <20191008160038.6xvnytnoruzphzd6@Ergus> <83zhibw6qn.fsf@gnu.org> <20191008164048.bnad4wdkcbatqepp@Ergus> <83v9szw4o4.fsf@gnu.org> <20191008234350.ahxt4zcylxqludoc@Ergus> <837e5ewc0a.fsf@gnu.org> <20191009103936.qjdwuidqnowswojw@Ergus> <83wodeup6a.fsf@gnu.org> <20191009120534.ud6st2xvrv3rv6iy@Ergus> <83pnj6umjx.fsf@gnu.org> <191fdb9e-a0ad-62d5-b214-fead90ec4bda@gmx.at> <83zhi9u57j.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="45428"; mail-complaints-to="usenet@blaine.gmane.org" Cc: spacibba@aol.com, juri@linkov.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 10 11:21:21 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIUdN-000BgH-5E for ged-emacs-devel@m.gmane.org; Thu, 10 Oct 2019 11:21:21 +0200 Original-Received: from localhost ([::1]:35562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIUdK-0000i4-20 for ged-emacs-devel@m.gmane.org; Thu, 10 Oct 2019 05:21:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35818) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIUZ4-0008VD-HU for emacs-devel@gnu.org; Thu, 10 Oct 2019 05:16:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIUZ3-000153-3M for emacs-devel@gnu.org; Thu, 10 Oct 2019 05:16:54 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:45921) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iIUYN-0000kG-F0; Thu, 10 Oct 2019 05:16:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1570698958; bh=jPZg3Mo12EV296ATN3RAEB1/E1oNVAxZ25PxA+J0RGk=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=fUbhu7S+GiXpTvtSEYUl0XqZgXKzD9MAvD45T4+otnhtwNScmxU1JL/44k7KaeaPZ tvgT6XESYnWQNGTDsA/NbXfA++JPANtMG39tB7a3BWc4gVKyC3eDA8O+PZlOBiraaZ cXCYE4YoYDA9k2pfiFNqUaj+slDHTQrWDT1oqdHE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.101] ([212.95.5.154]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mr9Bk-1hlqdU2kw2-00oIZO; Thu, 10 Oct 2019 11:15:58 +0200 In-Reply-To: <83zhi9u57j.fsf@gnu.org> Content-Language: de-AT X-Provags-ID: V03:K1:Ppibo592DtSaDlAWogYQBqGb2hW+567ERK2EjmS2HyriT0lif/C mlvIUMSg3F5GXHSS09o100cLurLq8hAkPZ6GIoZd6xtCSReLBHVYveD8EYGWmf0Bvv3Z8lV E/VzwEDvkpj9K56t+C4UzFRDBmJoJ1kWw8re3o0KY1kmrZ94ws/j1kT0ltcpSkIqWNhuXsw tcYXDvU7ZLor6WJg9DVXw== X-UI-Out-Filterresults: notjunk:1;V03:K0:es04/VqK9PE=:U4W5ZsCIbD5+dUrGm9Kc4s u/VapRoxA9XtO3R2Xn+s0oW9Dvjr8CDRekN2DmJ2b2065N8qj8MAuqjdCgSES+cuTY3T61Ggj qxzVaiXGlgFhh0Yo9vMupV9YPbvtq44dRBsdATVQzWRm83wzbtHlrixo0cuEYFDdNqUgKvYxG hwgvKv+GQSnEYHFV5K5JJ3UdgzsMBS579Zk2M4FU9th3td7pwKKaGVUVfP7B8KfNWxolbqb8N MbKOnMGiZH76tyOI4wMVLcbdPA+xFqMK0cc+9Cgb//kV0MqlMrykgffxcP+1lI626IBnE99yl UvUiDM3PyDMN5quMe9vYXllpgCZrOy4ltd2I2d9M4j2lph9fvx4GkapBi6zyZBhDqV5cbxMvH y2BzrMyRkLbsAOT+XIe7sp8x2uOJB7/vkQtD7GTYbhYr9doZweHobsKB4xrLO0n6vovT8+rVU XCIk0wHzRM5/ONU2+S+qZNgC/dlg2wrGyMNmAiT/IYZvP3eKEVuUlm1bZ9YbWsevv8OWcQlNI 6UtPou/I1RP03/u4OkcKqddhtCFoC/r8YgeMz0ufFLyJG4D+5GnmiIkmzksgw1hyL60cmY6fE 7PqGkOKfbcv7XWGd+QhKx7vDqzEXaUMmC79GymRDbUpyN2S80s2w3HaRcDhAfuw/bMeF26PfL m8wx6OfqJ4+JDnNnuduFOw2Yvwzqyepn5lKyFnhgvp3Yy2srpqCi+EFRGl9Tc3apNt/AOgvP/ Dfuia1Ms3/bq1fHHuWD91Ae/e2izLvi+9Mx2/0w1CntSV0+B78ZMxjQ5EVCK23IW1a7oeKiJ X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.15.19 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240824 Archived-At: > Ah, so these are one-off flags, and not indications of the resize, > i.e. they are not supposed to be sensitive to, say, when a tool bar > becomes too large for one line and needs two, is that so? They are one-off in the following sense: (1) Initially the flags are off. redisplay_tool_bar unconditionally sets f->tool_bar_redisplayed to true every time it runs, so redisplay_tool_bar is, by design, agnostic of the underlying mechanism. (2) The mechanism for exceptionally allowing to change the frame height when a tool bar height shall be established is confined to the change_tool_bar_height functions and their GTK counterpart. There, f->tool_bar_redisplayed is reset if certain conditions are met so any earlier calculation by redisplay_tool_bar is forgotten - don't ask me if such a calculation could have happened in practice, I don't remember. In either case the mechanism is only sharpened here and as we have seen with Bug#37609 its effect may trigger a long time after the initial frame has been made. Maybe we could inhibit it by having any caller(s) of redisplay_tool_bar set f->tool_bar_redisplayed even if they do not call redisplay_tool_bar. But I'm not sure. ISTR that I tried alternative solutions for this but was always surprised at how late in the frame creation phase the tool bar could take on its final, exact size. (3) Once the frame has been made and f->tool_bar_resized is set, the latter is never reset again and it's really one-off in the sense you described. >> As you mentioned earlier, tab bars are initially off and the tool bar >> is on. Maybe that's the cause of the problem. > > No, I think the cause of the problem is that we have no equivalent of > "C-x 6 f" that turns on the tool bar as a side effect of a command > that displays a buffer. I'm missing you here. Do you mean that displaying a tool bar for the first time in an Emacs session on a specific frame when you display a certain buffer on that frame would have a similar dramatic effect? Couldn't you verify that? > But that's a guess, because I've just > established with Jimmy's help that even the call to redraw_frame > doesn't cause the expected effect. Which completely stumps me, and I > need to think about it before I come with more ideas (_if_ I come with > more ideas)... I'm still not entirely sure whether it was a good idea to cargo cult the tab bar code from the tool bar code. Not that I have a substantially better offer. As a matter of fact, we should have provided a good pseudo window mechanism for that. martin