From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Johan Andersson <johan.rejeep@gmail.com>, 16762@debbugs.gnu.org
Subject: bug#16762: Installed packages are not considered part of the archive contents
Date: Sun, 23 Mar 2014 10:16:40 +0200 [thread overview]
Message-ID: <532E9868.60207@yandex.ru> (raw)
In-Reply-To: <jwvlhw3rlzw.fsf-monnier+emacsbugs@gnu.org>
On 22.03.2014 04:46, Stefan Monnier wrote:
> Yes, but as long as we don't know why this was done, it's too risky to
> change it. If/when we figure out what that was about and come up with
> a way to fix the problem, we can judge whether that's appropriate for
> 24.4.
From what I can see, except `package-install', all places where
`package-archive-contents' is used, either append its contents to
`package-alist' elements, or use a predicate calling `package-installed-p'.
The following patch seems to offer the same functionality:
=== modified file 'lisp/emacs-lisp/package.el'
--- lisp/emacs-lisp/package.el 2014-03-22 08:43:30 +0000
+++ lisp/emacs-lisp/package.el 2014-03-23 08:03:37 +0000
@@ -1047,14 +1047,11 @@
(existing-packages (assq name package-archive-contents))
(pinned-to-archive (assoc name package-pinned-packages)))
(cond
- ;; Skip entirely if pinned to another archive or already installed.
+ ;; Skip entirely if pinned to another archive or built-in.
((or (and pinned-to-archive
(not (equal (cdr pinned-to-archive) archive)))
(let ((bi (assq name package--builtin-versions)))
- (and bi (version-list-= version (cdr bi))))
- (let ((ins (cdr (assq name package-alist))))
- (and ins (version-list-= version
- (package-desc-version (car ins))))))
+ (and bi (version-list-= version (cdr bi)))))
nil)
((not existing-packages)
(push (list name pkg-desc) package-archive-contents))
@@ -1090,8 +1087,11 @@
(package-refresh-contents))
(list (intern (completing-read
"Install package: "
- (mapcar (lambda (elt) (symbol-name (car elt)))
- package-archive-contents)
+ (delq nil
+ (mapcar (lambda (elt)
+ (unless (package-installed-p (car elt))
+ (symbol-name (car elt))))
+ package-archive-contents))
nil t)))))
(package-download-transaction
(if (package-desc-p pkg)
next prev parent reply other threads:[~2014-03-23 8:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 16:06 bug#16762: Installed packages are not considered part of the archive contents Johan Andersson
2014-03-21 6:47 ` Dmitry Gutov
2014-03-21 15:33 ` Stefan Monnier
2014-03-21 23:07 ` Dmitry Gutov
2014-03-22 2:46 ` Stefan Monnier
2014-03-23 8:16 ` Dmitry Gutov [this message]
2014-03-24 0:55 ` Stefan
2014-03-24 6:20 ` Dmitry Gutov
2014-03-24 8:10 ` Johan Andersson
2014-03-24 13:07 ` Stefan
2014-03-24 14:32 ` Dmitry Gutov
2014-03-24 18:17 ` Stefan
2014-03-24 22:39 ` Dmitry Gutov
2014-03-28 7:22 ` Johan Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532E9868.60207@yandex.ru \
--to=dgutov@yandex.ru \
--cc=16762@debbugs.gnu.org \
--cc=johan.rejeep@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.