From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: Changes that should go into version 24.4 Date: Sat, 22 Mar 2014 02:15:12 -0700 Message-ID: <532D54A0.8090005@dancol.org> References: <532CEDEF.90707@dancol.org> <83pple4n41.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AnmBPDm6PdCnGvBs2cBl2PnweCgnH5r82" X-Trace: ger.gmane.org 1395479721 4495 80.91.229.3 (22 Mar 2014 09:15:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 22 Mar 2014 09:15:21 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 22 10:15:30 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WRI1Z-0000vK-8O for ged-emacs-devel@m.gmane.org; Sat, 22 Mar 2014 10:15:29 +0100 Original-Received: from localhost ([::1]:56222 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRI1Y-0000lM-Pj for ged-emacs-devel@m.gmane.org; Sat, 22 Mar 2014 05:15:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRI1T-0000kP-6x for emacs-devel@gnu.org; Sat, 22 Mar 2014 05:15:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WRI1S-00084Y-E4 for emacs-devel@gnu.org; Sat, 22 Mar 2014 05:15:23 -0400 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:36887) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRI1P-00083m-Bb; Sat, 22 Mar 2014 05:15:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=dy3P/tkeE1o1jqWBjsbw+YNUtoKLdgzoNBeoXnbFUKo=; b=fIFuheC77P58RV5A0WPRYbKiFQolTl76u8ySoy64ib9YO8yaF+UuYr4dE6/Q6xQ68ylMgU+wmI+pRQ0MKyDoZY10I2mrdC1MisgrVkGzefm1kkyxqAx9HREPtWJBhYZdf5ukjsuX6zS1S/GiPXMQT7EKNVvog0eAB7DS2bvOXpqh81catYKqWy1tE6fpDNzoeAHgFlQ5xFVGYH9kDxtSroNtWP7NxDWNQ2tPueLx+32WksK56PcuWmFoj53chScpCTZ1qvREgnoxV4lGqOz7aMA7LxBN4oBI9Z/kx1XvCL2u163L6efjwsUVEfREXwYsT8dYn1E7sVQtf+zFxFGAYA==; Original-Received: from [2620:0:1cfe:99::6] by dancol.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1WRI1O-0004Ip-Jp; Sat, 22 Mar 2014 02:15:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 In-Reply-To: <83pple4n41.fsf@gnu.org> X-Enigmail-Version: 1.6 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:170777 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AnmBPDm6PdCnGvBs2cBl2PnweCgnH5r82 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 03/22/2014 02:08 AM, Eli Zaretskii wrote: >> Date: Fri, 21 Mar 2014 18:57:03 -0700 >> From: Daniel Colascione >> >> It doesn't make sense that we'd fault accessing a stack slot on an >> active frame: doing so might corrupt something later, sure, but that >> stack location is valid and touching it isn't going to cause an >> immediate SIGSEGV. >=20 > Crashes in mark_object usually have nothing to do with accessing a > stack slot per se. mark_object looks at the object type, and then > extracts a pointer to a C structure from it, and proceeds treating > that pointer as a valid pointer to a valid structure of that type. If > pointer it extracts is invalid, or points to something that is not a C > struct of the type mark_object expects, we will segfault trying to > interpret those. >=20 Ah, yes. I was reading the message about the crash occurring "when mark_stack calls mark_memory". mark_object makes a lot more sense. (I read through the rest of the thread, but must have decoded "mark_object" as "mark_memory" based on the earlier message and the most recent message.) Thanks. --AnmBPDm6PdCnGvBs2cBl2PnweCgnH5r82 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTLVSgAAoJEMAaIROpHW7IamAP/3v8cM8jzICZ4ENqEmJGTOLL 6OMWOc5qV4FqNdkjKK2rv76gngckDwUZDsth1z4fmCbEycE23ZzEh1nartm3NQA9 /ijkh+vlcESImFkVMGB75X4Xh7xGFgSgB/WXPJ4Og1klo9qGkmezcPKKl5HMjODG M1RcXsCQ94U8xoglV4sGqbsXgWdLAeV1KOLuqPbHvUMkODq+7BY1yQvltd4MMZN5 LRuFdnYUULlCYef9ie6NeeaetDKfr/8szA2NMjLCEXH+hh9n+jya+ulYpsnTIBfx LRO/6KvX1mP1kcYWCANFKefmfdp6x9+UGOsnMPyV2iPqNR7UKqvSbLGXOeZMNwHx pmJIlu3FV1em7d0MS0M0xyfaCgHelSQQKJQff235+/GoizZn5JW7hUzWdWzNedOA 8BvxI3/zrjikGBNmrumGukSYyqgCxZviBEJGVyoxWsBD/cs/0yLa/Gw8swwIphGl rXt9Rs1x20KSyFe6kSnniVoCNOrPFJ7U6VIAOuWkl+wHzuMzjvZOwfaDAaqUagrf gApXgoOomgLa6wCXNtgZFxFMClRBIf3xvqwOx0DTBq91B6//8u5qzuwisMypR58h HSD6IdN6EyHs1ObZXeQ3OB1GY3DW62tS4eojiw5OM7t3nRUUG5nJ+ryiVuXAOYhU YGahvCJAeuZn61TkAAXa =zb2W -----END PGP SIGNATURE----- --AnmBPDm6PdCnGvBs2cBl2PnweCgnH5r82--