From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: Redisplay problems? Date: Thu, 20 Mar 2014 10:52:32 +0100 Message-ID: <532ABA60.7000003@gmx.at> References: <87ppljg4ti.fsf@kanru-mozilla.corp.tpe1.mozilla.com> <5329C53B.3030008@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1395309193 11383 80.91.229.3 (20 Mar 2014 09:53:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Mar 2014 09:53:13 +0000 (UTC) Cc: Christian Lynbech , James Cloos , =?UTF-8?B?Ikthbi1SdSBDaGVuICjpmbPkvoPlpoIpIg==?= , emacs-devel@gnu.org To: Stefan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 20 10:53:19 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WQZf4-0003lw-QV for ged-emacs-devel@m.gmane.org; Thu, 20 Mar 2014 10:53:18 +0100 Original-Received: from localhost ([::1]:46080 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQZf3-0002U7-V1 for ged-emacs-devel@m.gmane.org; Thu, 20 Mar 2014 05:53:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQZes-0002Ch-5I for emacs-devel@gnu.org; Thu, 20 Mar 2014 05:53:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQZek-0006Tb-NW for emacs-devel@gnu.org; Thu, 20 Mar 2014 05:53:06 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:58929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQZek-0006Rz-CX for emacs-devel@gnu.org; Thu, 20 Mar 2014 05:52:58 -0400 Original-Received: from [93.82.73.87] ([93.82.73.87]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0LedVG-1WtWk92JIc-00qOKY; Thu, 20 Mar 2014 10:52:43 +0100 In-Reply-To: X-Provags-ID: V03:K0:dDOt2LXrBsTVXc2d8kE9G8Rg7chARRXDbjGh11UlbwlPOSon5al xLK7WsMiV0mS5hGRBm68BtUe8swVceBLGXs8NOK0Wr2okNf8hy1mKoNy5emgkW8pNJF3llf KzXOh4iaES5olLtVtscqAVlUxhlKtVPCenCZmF8jgHCkT7k1HH6rgCdyHVY1DHwnh0QAD2c JZ/1yRvbmU23y6cWL7rCg== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 212.227.17.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:170610 Archived-At: > I think my patch indeed fixes this problem by distinguishing between > f->garbaged (which presumably stops redrawing in Expose, tho I don't > offhand see where that happens) and frame_garbaged (which is needed to > get the next redisplay to be properly triggered and performed). IIUC my earlier proposal to SET_FRAME_GARBAGED unconditionally subsumes what you propose here because I set frame_garbaged and the garbaged slot of the frame that received the MapNotify event. However, since I set the garbaged slot unconditionally, your proposal provides a better check as to whether we previously have set a frame's garbaged slot correctly. Is that observation correct or am I missing something? > If it looks right, then we might reconsider the SET_FRAME_GARBAGED in > w32term.c in light of such a change, but that's even further away from > my expertise. I'm still struggling with the semantics of what a "garbaged frame" is and whether we always set the garbaged slot correctly. martin