Re: [Emacs-diffs] trunk r116793: Ensure dired-display-file displays it in other window.

Re: [Emacs-diffs] trunk r116793: Ensure dired-display-file displays it in other window.

[Daniel Colascione]

[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]

On 03/18/2014 05:10 AM, Richard M. Stallman wrote:
> ------------------------------------------------------------
> revno: 116793
> revision-id: rms@gnu.org-20140318120701-ugi59ohdr5hl46u1
> parent: lekktu@gmail.com-20140318112933-ajdrz34du2i1099y
> author: Richard Stallman
> committer: Richard Stallman <rms@gnu.org>
> branch nick: trunk
> timestamp: Tue 2014-03-18 08:07:01 -0400
> message:
>   Ensure dired-display-file displays it in other window.

This change also checks that -a is in dired switches. Please don't do that.

I'm also skeptical of the main hunk:

=== modified file 'lisp/dired.el'
--- a/lisp/dired.el	2014-03-16 09:26:58 +0000
+++ b/lisp/dired.el	2014-03-18 12:07:01 +0000
@@ -2136,7 +2136,8 @@
 (defun dired-display-file ()
   "In Dired, display this file or directory in another window."
   (interactive)
-  (display-buffer (find-file-noselect (dired-get-file-for-visit))))
+  (display-buffer (find-file-noselect (dired-get-file-for-visit))
+		  t))

What bug does that actually fix?


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

Re: [Emacs-diffs] trunk r116793: Ensure dired-display-file displays it in other window.

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

    This change also checks that -a is in dired switches. Please don't do that.

Oops, I thought I had deleted that change before checking it in.
I deleted it now.

    What bug does that actually fix?

The bug was that the file would appear in the same window, replacing
the Dired buffer.

-- 
Dr Richard Stallman
President, Free Software Foundation
51 Franklin St
Boston MA 02110
USA
www.fsf.org  www.gnu.org
Skype: No way! That's nonfree (freedom-denying) software.
  Use Ekiga or an ordinary phone call.