From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r116779: Restore compatibility with legacy comment-start-skip values Date: Mon, 17 Mar 2014 18:14:55 +0200 Message-ID: <53271F7F.8070308@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1395072920 5475 80.91.229.3 (17 Mar 2014 16:15:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 17 Mar 2014 16:15:20 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 17 17:15:27 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WPaCD-0001Rn-WA for ged-emacs-devel@m.gmane.org; Mon, 17 Mar 2014 17:15:26 +0100 Original-Received: from localhost ([::1]:58962 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPaCD-0003Eg-Ic for ged-emacs-devel@m.gmane.org; Mon, 17 Mar 2014 12:15:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPaBz-0003Ck-U9 for emacs-devel@gnu.org; Mon, 17 Mar 2014 12:15:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPaBp-0004di-Ka for emacs-devel@gnu.org; Mon, 17 Mar 2014 12:15:11 -0400 Original-Received: from mail-wg0-x22e.google.com ([2a00:1450:400c:c00::22e]:65303) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPaBp-0004ZC-Cx for emacs-devel@gnu.org; Mon, 17 Mar 2014 12:15:01 -0400 Original-Received: by mail-wg0-f46.google.com with SMTP id b13so4756288wgh.17 for ; Mon, 17 Mar 2014 09:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=6/nJAV+mGopRM3+IKnN2K/p6sXwAmw+V6Ljh1IkmzZE=; b=hgMbzQXzeVjPU1wRe9HAFJgqmGmBn35gf0yWEG0nukt3FudL4zsVgan5GciMkeF9iy 9a26hFN9375f2qqOBL2UAVJn0WYAmvPvBk59Gri2Sq2LGBDHxCc/WpdSoAU4vzeIR0GQ /D9Lbjl9FO4J716FuoXD4DunNcYA4vEx8tULGJGM5ffiY/RQdPoAT2DSUqeik6Ns7lZW Rkz+hwb9Zc/6VGz91G/yWlFXFzzfIHTEq6+LQ+ytYsbtS6+0ZwZsh1y8ii2Iy1dKiJcc XpScYhNNiTStp4U+fx5o/aoAad6HM8965WUpGUj+h1btiVTuV3Q2XW1za3T06vvRQSKq OfDQ== X-Received: by 10.181.13.40 with SMTP id ev8mr10493543wid.0.1395072900377; Mon, 17 Mar 2014 09:15:00 -0700 (PDT) Original-Received: from [192.168.0.94] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by mx.google.com with ESMTPSA id jd2sm26225513wic.9.2014.03.17.09.14.56 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 17 Mar 2014 09:14:58 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:170446 Archived-At: On 17.03.2014 17:50, Stefan wrote: >> + ;; Some older modes use regexps that check the >> + ;; char before the comment for quoting. (Bug#16971) In light of your latest message on #16971, I'll probably have to change this comment. >> + (save-excursion >> + (forward-char -1) >> + (looking-at comment-start-skip))) > > This needs to additionally check that (match-end 1) points to what we > thought was the comment start. Can you think of a situation when that's not true? And suppose it doesn't, then what?