all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: "João Távora" <joaotavora@gmail.com>
Cc: 17007@debbugs.gnu.org
Subject: bug#17007: 24.3.50; describe-key/function evaluates documentation function in the wrong	buffer
Date: Fri, 14 Mar 2014 12:32:16 +0100	[thread overview]
Message-ID: <5322E8C0.5020106@gmx.at> (raw)
In-Reply-To: <jjbtxb2ny13.fsf@gmail.com>

 > This has stopped working in 24.3.5 since `with-help-window' started
 > replaced `with-output-to-temp-buffer' with
 > `with-temp-buffer-window'. The former just binds `standard-output' while
 > the latter also sets the current buffer to the *Help* buffer.
 >
 > The result is that the fallback keybinding reported is always
 > "forward-button", which is almost always wrong.
 >
 > One could either
 >
 > 1. revert that change (was it just a cleanup?)
 > 2. fix/parametrize that particular behaviour of
 > `with-temp-buffer-window'
 > 3. pass an extra original-buffer arg to `describe-function-1'
 > 4. dynamically bind some new `help-original-buffer' var.
 >
 > Even though a better mechanism for "fallback keybindings" is being
 > discussed (and by then yasnippet can get rid of its own technique, which
 > is half-baked but working since emacs 22), it'd be nice if the current
 > function-documentation trick is kept working for upcoming emacs 24.4.
 >
 > This originated in https://github.com/capitaomorte/yasnippet/issues/468
 >
 > http://github.com/capitaomorte/autopair does something similar and is
 > probably also affected, but I plan to deprecate autopair in favor of
 > 24.4's electric-pair-mode anyway.

Sorry, I messed this up too often already.  Hopefully, it's sufficient
to add one `with-current-buffer' binding at some particular level.
Could you please send me the calling sequence used by yasnippet, so I
can identify the location where this is necessary?

martin





  parent reply	other threads:[~2014-03-14 11:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-13 11:22 bug#17007: 24.3.50; describe-key/function evaluates documentation function in the wrong buffer João Távora
2014-03-13 15:57 ` Glenn Morris
2014-03-13 16:29   ` João Távora
2014-03-13 19:18     ` João Távora
2014-03-14 11:32 ` martin rudalics [this message]
2014-03-14 12:08   ` João Távora
2014-03-14 14:34     ` martin rudalics
2014-03-14 15:05       ` Nicolas Richard
2014-03-14 17:42         ` martin rudalics
2014-03-16 10:02         ` martin rudalics
2014-03-16 11:45           ` Nicolas Richard
2014-03-16 13:27           ` João Távora
2014-03-19 10:50             ` Juanma Barranquero
2014-03-16 10:01     ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5322E8C0.5020106@gmx.at \
    --to=rudalics@gmx.at \
    --cc=17007@debbugs.gnu.org \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.