From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#20625: 25.0.50; doc of `define-error` is incorrect Date: Sat, 23 May 2015 09:02:56 -0700 (PDT) Message-ID: <531f0ede-5afb-4c72-bcaf-3ef56e447f1e@default> References: <<10eb5733-c84c-491d-86ca-2d6a05b80e7d@default>> <<83oalb1gvn.fsf@gnu.org>> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1432397068 5791 80.91.229.3 (23 May 2015 16:04:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 23 May 2015 16:04:28 +0000 (UTC) Cc: 20625@debbugs.gnu.org To: Eli Zaretskii , Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 23 18:04:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YwBuH-0005S9-T9 for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 May 2015 18:04:14 +0200 Original-Received: from localhost ([::1]:38084 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YwBuH-0001XZ-AY for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 May 2015 12:04:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YwBuA-0001XU-T6 for bug-gnu-emacs@gnu.org; Sat, 23 May 2015 12:04:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YwBu6-0005IL-T5 for bug-gnu-emacs@gnu.org; Sat, 23 May 2015 12:04:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44126) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YwBu6-0005IH-PL for bug-gnu-emacs@gnu.org; Sat, 23 May 2015 12:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YwBu6-0005P5-Jd for bug-gnu-emacs@gnu.org; Sat, 23 May 2015 12:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 May 2015 16:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20625 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20625-submit@debbugs.gnu.org id=B20625.143239699220706 (code B ref 20625); Sat, 23 May 2015 16:04:02 +0000 Original-Received: (at 20625) by debbugs.gnu.org; 23 May 2015 16:03:12 +0000 Original-Received: from localhost ([127.0.0.1]:54101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YwBtE-0005Np-AQ for submit@debbugs.gnu.org; Sat, 23 May 2015 12:03:12 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:41041) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YwBt9-0005N7-2u for 20625@debbugs.gnu.org; Sat, 23 May 2015 12:03:07 -0400 Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t4NG2uK3015989 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 23 May 2015 16:02:56 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t4NG2tTP025014 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sat, 23 May 2015 16:02:55 GMT Original-Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t4NG2tpA001445; Sat, 23 May 2015 16:02:55 GMT In-Reply-To: <<83oalb1gvn.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103111 Archived-At: > I've grepped all the uses of 'error-message property in the Emacs > sources, and I only see uses that expect the value to be a string. What can I say, beyond what I said? I don't think that is really relevant. A nil value means (I think) precisely that an error condition is declared that has no associated message string. The fact that no code makes use of such an error condition doesn't mean anything significant, IMO. IIUC, the use of `bookmark-errors' with a nil value in bookmark.el is precisely the same as its use of `bookmark-errors' with `error-condition' prior to Emacs 24.4. It declares, even if it does not define an error message for, an error condition that is more general than `bookmark-error-no-filename'. It tells programmers who might define their own bookmark errors to have them, like `bookmark-error-no-filename', inherit from condition `bookmark-errors'. That seems reasonable to me. But of course it is not necessary - users can just have their new bookmark errors inherit from `error'. Now you could argue that the presence of `bookmark-errors' in bookmark.el prior to Emacs 24.4 was a mistake. That is the same argument as saying that its presence now is a mistake. But if you suppose that it is a good idea to predefine a general error class for bookmark code, then I don't see why doing so using `define-error' is any less meaningful/reasonable than doing so using property `error-conditions' directly. > I cannot describe in the docs something I don't understand. I hope > someone who will would either fix the docs or post here what it > means for that property to have a nil value, and then I can put > that in the docs. I tried to explain the meaning, as I understand it. Perhaps the person who changed the Emacs 24.3 bookmark.el code to use `define-error', or the person who introduced `define-error' to Emacs 24.4, can confirm what I said or otherwise weigh in here. Meanwhile, perhaps you could consider mentioning that the MESSAGE value can be nil. (This doc bug would remain open, as long as what nil means is not described, but at least the type of MESSAGE would not be incorrectly specified). And perhaps you could consider making parameter MESSAGE optional (since, in effect, it is).