From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Seiji Zenitani Newsgroups: gmane.emacs.devel Subject: Re: OS X: raise-frame at reopen event Date: Tue, 16 Oct 2007 22:30:38 -0400 Message-ID: <53181D51-1494-45D1-9D60-5D528E67EE94@mac.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1192588293 32515 80.91.229.12 (17 Oct 2007 02:31:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 17 Oct 2007 02:31:33 +0000 (UTC) Cc: emacs-devel@gnu.org To: YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 17 04:31:33 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ihyh2-0000i0-Mk for ged-emacs-devel@m.gmane.org; Wed, 17 Oct 2007 04:31:33 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ihygv-00036N-Q6 for ged-emacs-devel@m.gmane.org; Tue, 16 Oct 2007 22:31:25 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ihygq-00035n-NV for emacs-devel@gnu.org; Tue, 16 Oct 2007 22:31:20 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ihygp-00035P-6p for emacs-devel@gnu.org; Tue, 16 Oct 2007 22:31:20 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ihygp-00035K-3o for emacs-devel@gnu.org; Tue, 16 Oct 2007 22:31:19 -0400 Original-Received: from smtpoutm.mac.com ([17.148.16.71]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ihygo-0003da-8G for emacs-devel@gnu.org; Tue, 16 Oct 2007 22:31:18 -0400 Original-Received: from mac.com (asmtp005-s [10.150.69.68]) by smtpoutm.mac.com (Xserve/smtpout008/MantshX 4.0) with ESMTP id l9H2VG1l021039; Tue, 16 Oct 2007 19:31:16 -0700 (PDT) Original-Received: from [10.0.1.199] (c-68-55-160-31.hsd1.md.comcast.net [68.55.160.31]) (authenticated bits=0) by mac.com (Xserve/asmtp005/MantshX 4.0) with ESMTP id l9H2VDn4002054; Tue, 16 Oct 2007 19:31:14 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.752.3) X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.8-5.1 (or MacOS X 10.2-10.3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:81041 Archived-At: Yamamoto-san, Two months ago, you installed the reopen-frame patch to the trunk for the Mac Carbon port. Could you install it to EMACS_22_BASE, too? I have been using the patch on the EMACS_22_BASE branch since then, but I have no problem yet. Seiji Zenitani zenitani@mac.com On 2007/08/10, at 9:40, Seiji Zenitani wrote: > Thank you for your quick response. > Is it possible to apply the patch to EMACS_22_BASE, too? > I think the below change is harmless. > > Seiji Zenitani > zenitani@mac.com > > On 2007/08/10, at 6:18, YAMAMOTO Mitsuharu wrote: > >>>>>>> On Thu, 09 Aug 2007 15:35:08 -0700, Seiji Zenitani >>>>>>> said: >> >>> How about modifying 'ignore to 'raise-frame in mac-win.el? >> >> `raise-frame' may make an invisible frame visible. I've installed >> the >> following change to the trunk. >> >> YAMAMOTO Mitsuharu >> mituharu@math.s.chiba-u.ac.jp >> >> Index: lisp/term/mac-win.el >> =================================================================== >> RCS file: /cvsroot/emacs/emacs/lisp/term/mac-win.el,v >> retrieving revision 1.91 >> diff -c -p -r1.91 mac-win.el >> *** lisp/term/mac-win.el 26 Jul 2007 05:27:30 -0000 1.91 >> --- lisp/term/mac-win.el 10 Aug 2007 10:09:17 -0000 >> *************** in `selection-converter-alist', which se >> *** 1710,1715 **** >> --- 1710,1728 ---- >> (setq modifiers (cons (car modifier-mask) modifiers))))) >> modifiers)) >> >> + (defun mac-ae-reopen-application (event) >> + "Show some frame in response to the Apple event EVENT. >> + The frame to be shown is chosen from visible or iconified frames >> + if possible. If there's no such frame, a new frame is created." >> + (interactive "e") >> + (unless (frame-visible-p (selected-frame)) >> + (let ((frame (or (car (visible-frame-list)) >> + (car (filtered-frame-list 'frame-visible-p))))) >> + (if frame >> + (select-frame frame) >> + (switch-to-buffer-other-frame "*scratch*")))) >> + (select-frame-set-input-focus (selected-frame))) >> + >> (defun mac-ae-open-documents (event) >> "Open the documents specified by the Apple event EVENT." >> (interactive "e") >> *************** Currently the `mailto' scheme is support >> *** 1766,1774 **** >> (define-key mac-apple-event-map [core-event open-application] 0) >> >> ;; Received when a dock or application icon is clicked and Emacs is >> ! ;; already running. Simply ignored. Another idea is to make a new >> ! ;; frame if all frames are invisible. >> ! (define-key mac-apple-event-map [core-event reopen-application] >> 'ignore) >> >> (define-key mac-apple-event-map [core-event open-documents] >> 'mac-ae-open-documents) >> --- 1779,1787 ---- >> (define-key mac-apple-event-map [core-event open-application] 0) >> >> ;; Received when a dock or application icon is clicked and Emacs is >> ! ;; already running. >> ! (define-key mac-apple-event-map [core-event reopen-application] >> ! 'mac-ae-reopen-application) >> >> (define-key mac-apple-event-map [core-event open-documents] >> 'mac-ae-open-documents)