From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#16892: 24.3; terminal corruption after emacsclient -t & Date: Wed, 05 Mar 2014 00:07:00 -0800 Organization: UCLA Computer Science Department Message-ID: <5316DB24.9010704@cs.ucla.edu> References: <87mwhc64wx.fsf@msstf091.ucc.ie> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------000602090206080507050608" X-Trace: ger.gmane.org 1394006894 29594 80.91.229.3 (5 Mar 2014 08:08:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 5 Mar 2014 08:08:14 +0000 (UTC) To: 16892@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 05 09:08:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WL6sI-0006yJ-Id for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Mar 2014 09:08:22 +0100 Original-Received: from localhost ([::1]:50577 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WL6sH-0004SO-Uu for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Mar 2014 03:08:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WL6s9-0004SA-4H for bug-gnu-emacs@gnu.org; Wed, 05 Mar 2014 03:08:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WL6ry-0005sp-FP for bug-gnu-emacs@gnu.org; Wed, 05 Mar 2014 03:08:13 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WL6ry-0005sk-Bi for bug-gnu-emacs@gnu.org; Wed, 05 Mar 2014 03:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WL6ry-0003Yt-0E for bug-gnu-emacs@gnu.org; Wed, 05 Mar 2014 03:08:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87mwhc64wx.fsf@msstf091.ucc.ie> Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Mar 2014 08:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16892 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 16892-submit@debbugs.gnu.org id=B16892.139400682613591 (code B ref 16892); Wed, 05 Mar 2014 08:08:01 +0000 Original-Received: (at 16892) by debbugs.gnu.org; 5 Mar 2014 08:07:06 +0000 Original-Received: from localhost ([127.0.0.1]:51041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WL6r3-0003X8-M7 for submit@debbugs.gnu.org; Wed, 05 Mar 2014 03:07:05 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:55493) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WL6r0-0003Wr-L8 for 16892@debbugs.gnu.org; Wed, 05 Mar 2014 03:07:03 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id DD57A39E8015 for <16892@debbugs.gnu.org>; Wed, 5 Mar 2014 00:07:01 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id li2uoTpfEuG4 for <16892@debbugs.gnu.org>; Wed, 5 Mar 2014 00:07:01 -0800 (PST) Original-Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 012D039E8008 for <16892@debbugs.gnu.org>; Wed, 5 Mar 2014 00:07:00 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86568 Archived-At: This is a multi-part message in MIME format. --------------000602090206080507050608 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for the bug report. How about the attached (untested) patch instead? It checks for tcgetpgrp failure. Also, the glibc manual suggests that emacsclient should be killing its process group with SIGTTIN, not itself with SIGSTOP. See: http://www.gnu.org/software/libc/manual/html_node/Foreground-and-Background.html --------------000602090206080507050608 Content-Type: text/plain; charset=UTF-8; name="emacsclient.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="emacsclient.diff" PT09IG1vZGlmaWVkIGZpbGUgJ2xpYi1zcmMvZW1hY3NjbGllbnQuYycKLS0tIGxpYi1zcmMv ZW1hY3NjbGllbnQuYwkyMDE0LTAyLTI1IDE5OjA2OjUzICswMDAwCisrKyBsaWItc3JjL2Vt YWNzY2xpZW50LmMJMjAxNC0wMy0wNSAwNzo1OTozMyArMDAwMApAQCAtMTEwNSwxNiArMTEw NSwxOCBAQAogaGFuZGxlX3NpZ2NvbnQgKGludCBzaWduYWxudW0pCiB7CiAgIGludCBvbGRf ZXJybm8gPSBlcnJubzsKKyAgcGlkX3QgcGdycCA9IGdldHBncnAgKCk7CisgIHBpZF90IHRj cGdycCA9IHRjZ2V0cGdycCAoMSk7CiAKLSAgaWYgKHRjZ2V0cGdycCAoMSkgPT0gZ2V0cGdy cCAoKSkKKyAgaWYgKHRjcGdycCA9PSBwZ3JwKQogICAgIHsKICAgICAgIC8qIFdlIGFyZSBp biB0aGUgZm9yZWdyb3VuZC4gICovCiAgICAgICBzZW5kX3RvX2VtYWNzIChlbWFjc19zb2Nr ZXQsICItcmVzdW1lIFxuIik7CiAgICAgfQotICBlbHNlIGlmICh0dHkpCisgIGVsc2UgaWYg KDAgPD0gdGNwZ3JwICYmIHR0eSkKICAgICB7CiAgICAgICAvKiBXZSBhcmUgaW4gdGhlIGJh Y2tncm91bmQ7IGNhbmNlbCB0aGUgY29udGludWUuICAqLwotICAgICAgcmFpc2UgKFNJR1NU T1ApOworICAgICAga2lsbCAoLXBncnAsIFNJR1RUSU4pOwogICAgIH0KIAogICBzaWduYWwg KHNpZ25hbG51bSwgaGFuZGxlX3NpZ2NvbnQpOwpAQCAtMTU1NCw2ICsxNTU2LDE0IEBACiAg ICAgICBleGl0IChFWElUX0ZBSUxVUkUpOwogICAgIH0KIAorICBpZiAodHR5KQorICAgIHsK KyAgICAgIHBpZF90IHBncnAgPSBnZXRwZ3JwICgpOworICAgICAgcGlkX3QgdGNwZ3JwID0g dGNnZXRwZ3JwICgxKTsKKyAgICAgIGlmICgwIDw9IHRjcGdycCAmJiB0Y3BncnAgIT0gcGdy cCkKKwlraWxsICgtcGdycCwgU0lHVFRJTik7CisgICAgfQorCiAgIC8qIElmIGFsdGVybmF0 ZV9lZGl0b3IgaXMgdGhlIGVtcHR5IHN0cmluZywgc3RhcnQgdGhlIGVtYWNzIGRhZW1vbgog ICAgICBpbiBjYXNlIG9mIGZhaWx1cmUgdG8gY29ubmVjdC4gICovCiAgIHN0YXJ0X2RhZW1v bl9pZl9uZWVkZWQgPSAoYWx0ZXJuYXRlX2VkaXRvcgoK --------------000602090206080507050608--