all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 16897@debbugs.gnu.org
Subject: bug#16897: 24.3.50; vc-print-root-log doesn't show the top commit if it's a merge commit
Date: Sat, 01 Mar 2014 08:17:21 +0200	[thread overview]
Message-ID: <53117B71.3040200@yandex.ru> (raw)
In-Reply-To: <jwvy50vi245.fsf-monnier+emacsbugs@gnu.org>

On 28.02.2014 19:24, Stefan Monnier wrote:
>>> Yes, something like that is needed for other circumstances as well,
>> Do you mean other uses of `vc-git-print-log'?
>
> No: other circumstances where we pass a list of files to Git.
> IOW, maybe vc-git-command should support turning a (list
> default-directory) into nil.

This sort of assumes that default-directory is always the root dir. 
Which isn't true.

Of course it seems that in practice, whenever file-or-list is the same 
as (list default-directory), the latter *is* the root dir. But that's a 
shaky assumption.

I'm not sure I want to spend another process call to determine what the 
actual root dir is each time, so maybe we should limit the fix to 
`vc-git-print-log'.

At least, until any other command is known to exhibit a similar bug.





  reply	other threads:[~2014-03-01  6:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-27 17:57 bug#16897: 24.3.50; vc-print-root-log doesn't show the top commit if it's a merge commit Dmitry Gutov
2014-02-28 13:48 ` Stefan Monnier
2014-02-28 14:23   ` Dmitry Gutov
2014-02-28 17:24     ` Stefan Monnier
2014-03-01  6:17       ` Dmitry Gutov [this message]
2014-03-01 17:13         ` Stefan Monnier
2014-03-02  2:44           ` Dmitry Gutov
2014-03-07 20:54             ` Stefan Monnier
2014-03-08  0:48               ` Dmitry Gutov
2014-03-08  7:02               ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53117B71.3040200@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=16897@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.