From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#21804: 25.0.50; file-notify-tests failure on Cygwin Date: Fri, 30 Dec 2016 17:19:03 -0500 Message-ID: <52f2d693-8688-f556-fa35-b74b4b21f566@cornell.edu> References: <563634F7.2070606@cornell.edu> <8737wpipy8.fsf@gmx.de> <87a8qv6lu2.fsf@gmx.de> <5639818A.5090307@cornell.edu> <87ziyugoqr.fsf@gmx.de> <563A3890.6030707@cornell.edu> <87si4lhaeq.fsf@gmx.de> <563ACB3F.5080709@cornell.edu> <87y4ecnrpp.fsf@gmx.de> <87r34tmv9m.fsf@gmx.de> <87h95pp6dd.fsf@gmx.de> <87zijek10s.fsf@gmx.de> <83a8bdu7gl.fsf@gnu.org> <87vau1jkx2.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1483136415 6709 195.159.176.226 (30 Dec 2016 22:20:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 30 Dec 2016 22:20:15 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 Cc: 21804@debbugs.gnu.org To: Michael Albinus , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 30 23:20:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cN5Ww-0000pQ-M3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Dec 2016 23:20:06 +0100 Original-Received: from localhost ([::1]:41688 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cN5X1-0008Jv-Iw for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Dec 2016 17:20:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cN5Wv-0008Ij-Sh for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2016 17:20:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cN5Ws-00011N-PC for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2016 17:20:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45260) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cN5Ws-00011F-MG for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2016 17:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cN5Ws-0003uz-Eq for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2016 17:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Dec 2016 22:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21804 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21804-submit@debbugs.gnu.org id=B21804.148313635314999 (code B ref 21804); Fri, 30 Dec 2016 22:20:02 +0000 Original-Received: (at 21804) by debbugs.gnu.org; 30 Dec 2016 22:19:13 +0000 Original-Received: from localhost ([127.0.0.1]:60659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cN5W4-0003tr-TJ for submit@debbugs.gnu.org; Fri, 30 Dec 2016 17:19:13 -0500 Original-Received: from limerock02.mail.cornell.edu ([128.84.13.242]:43672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cN5W3-0003tf-Rs for 21804@debbugs.gnu.org; Fri, 30 Dec 2016 17:19:12 -0500 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock02.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id uBUMJ5Ax006510; Fri, 30 Dec 2016 17:19:05 -0500 Original-Received: from [192.168.1.9] (mta-68-175-148-36.twcny.rr.com [68.175.148.36] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id uBUMJ3Ts002930 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 30 Dec 2016 17:19:04 -0500 In-Reply-To: <87vau1jkx2.fsf@gmx.de> X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127599 Archived-At: On 12/30/2016 2:07 PM, Michael Albinus wrote: > Eli Zaretskii writes: > >>> - (string-equal (file-notify--test-monitor) "GPollFileMonitor")) >>> + (or (string-equal (file-notify--test-monitor) "GPollFileMonitor") >>> + (string-equal (file-notify--test-monitor) "GFamFileMonitor"))) >> >> Wouldn't it be better if gfile-monitor-name returned a symbol instead >> of a string? That's our general convention with functions, I think. > > I've changed it accordingly. But since it returns an uninterned symbol, I think I still need to use string-equal above. Or am I misunderstanding something? Ken