From: Dmitry Gutov <dgutov@yandex.ru>
To: Randy Taylor <dev@rjt.dev>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: font-lock-delimiter-face - what for?
Date: Wed, 28 Dec 2022 20:32:15 +0200 [thread overview]
Message-ID: <52efe7a5-af9d-5db6-2584-456173d46ec5@yandex.ru> (raw)
In-Reply-To: <oaXjfVoeYH6Uue__4aps5R_7WQJffhJhwEHcUigZJ4Tqd8fze5zmrRQD8ryNeb66KoKHAGqEDCQhZes9CAe3ihcCdXKNCpQLb5KY74mvHWc=@rjt.dev>
On 28/12/2022 19:06, Randy Taylor wrote:
> On Wednesday, December 28th, 2022 at 10:13, Dmitry Gutov <dgutov@yandex.ru> wrote:
>>
>> Maybe it would be better to remove font-lock-misc-punctuation-face, though?
>>
>> People can still use font-lock-punctuation-face for everything
>> punctuation-like that doesn't match the category of "brackets" or
>> "delimiters".
>>
>> Just like font-lock-doc-face inherits from font-lock-string-face, or
>> font-lock-comment-delimiter-face inherits from font-lock-comment-face.
>>
>> We don't seem to have a practice of "parent faces" which are otherwise
>> unused. font-lock-punctuation-face's docstring doesn't suggest this kind
>> of purpose either.
>
> Then we should get rid of font-lock-punctuation-face instead. If we keep it and use it in place of misc-punctuation, then changing punctuation-face would also change the bracket and delimiter faces, since they inherit from it.
That's usually how inheriting works, yes.
Do we anticipate misc-punctuation to often have unique attributes? If
so, it might be at least some reason to keep that face.
> font-lock-punctuation-face wouldn't be a great name either since it's no longer referring to all punctuation (which is its current goal, and the docstring can always be updated).
Why wouldn't it be referring to all punctuation? All attributes that are
not overridden by bracket- and delimiter- faces will show up in them.
next prev parent reply other threads:[~2022-12-28 18:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 15:44 font-lock-delimiter-face - what for? Dmitry Gutov
2022-12-27 16:44 ` Randy Taylor
2022-12-27 16:54 ` Dmitry Gutov
2022-12-27 18:20 ` Randy Taylor
2022-12-27 19:45 ` Dmitry Gutov
2022-12-27 21:01 ` Stefan Monnier
2022-12-27 21:34 ` Dmitry Gutov
2022-12-28 15:13 ` Dmitry Gutov
2022-12-28 17:06 ` Randy Taylor
2022-12-28 18:32 ` Dmitry Gutov [this message]
2022-12-29 3:46 ` Randy Taylor
2022-12-29 15:57 ` Dmitry Gutov
2022-12-29 18:41 ` Randy Taylor
2022-12-30 4:59 ` Yuan Fu
2022-12-27 17:00 ` Eli Zaretskii
2022-12-27 19:46 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52efe7a5-af9d-5db6-2584-456173d46ec5@yandex.ru \
--to=dgutov@yandex.ru \
--cc=dev@rjt.dev \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.