Re: completion-at-point + semantic : erroneous error

[Eric Ludlam <ericludlam@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1802 bytes --]

On 10/23/19 4:18 PM, Stefan Monnier wrote:
>> As a followup, I started using the shorter version of your patch, and found
>> there are additional errors thrown from
>> semantic-analyze-possible-completions-default (what will be a method in
>> your patch).  I had to eliminate those errors to fully clean up the original
>> problem that started this thread.
> [ Sorry for taking so long to get back to it.  ]
>
> After fighting for a while with your patch (it was full of NBSP chars
> and wrapped lines) and then looking at it some more, I decided to
> install the patch below instead which replaces the `catch` with
> a `with-demoted-errors` (and places it in the caller instead).
> Maybe those errors should indeed all be replaced by silently returning
> nil, but the code currently goes through the trouble of building
> more precise error messages, so I felt like maybe we should preserve
> that info.

Hi Stefan,

I pulled down the latest, and ran against a more extensive test suite 
I'm working on.  I found that the new version is always pushing down the 
optional 'flags input to overrides, which makes sense.  Several override 
methods don't accommodate this.  The attached patch adds that optional 
'flags' input to fix the error and allow the make, texi, and grammar 
modes run their specialization.

> Ah, right.  I too have debug-on-error non-nil of course.
> The `error`s should be turned into `user-error`s to avoid this problem.

> Tho of course, if the corresponding messages are not useful, returning
> nil is a better choice, indeed.

user-error sounds like the shortest path here.  The original purpose of 
the error was to provide a fine-grained reason for why something may 
have failed to complete.  I think most completion engines don't care 
about that.

Thanks

Eric




[-- Attachment #2: optflags.patch --]
[-- Type: text/x-patch, Size: 1761 bytes --]

diff --git a/lisp/cedet/semantic/bovine/make.el b/lisp/cedet/semantic/bovine/make.el
index 3676c6972f..01a15b8232 100644
--- a/lisp/cedet/semantic/bovine/make.el
+++ b/lisp/cedet/semantic/bovine/make.el
@@ -175,7 +175,7 @@ semantic-format-tag-uml-prototype
   (semantic-format-tag-prototype tag parent color))
 
 (define-mode-local-override semantic-analyze-possible-completions
-  makefile-mode (context)
+  makefile-mode (context &rest flags)
   "Return a list of possible completions in a Makefile.
 Uses default implementation, and also gets a list of filenames."
   (require 'semantic/analyze/complete)
diff --git a/lisp/cedet/semantic/grammar.el b/lisp/cedet/semantic/grammar.el
index 813580ba6c..e1337b3eb9 100644
--- a/lisp/cedet/semantic/grammar.el
+++ b/lisp/cedet/semantic/grammar.el
@@ -1915,7 +1915,7 @@ semantic-analyze-current-context
       context-return)))
 
 (define-mode-local-override semantic-analyze-possible-completions
-  semantic-grammar-mode (context)
+  semantic-grammar-mode (context &rest flags)
   "Return a list of possible completions based on CONTEXT."
   (require 'semantic/analyze/complete)
   (if (semantic-grammar-in-lisp-p)
diff --git a/lisp/cedet/semantic/texi.el b/lisp/cedet/semantic/texi.el
index 73f0e734f3..0fdc9ee8bc 100644
--- a/lisp/cedet/semantic/texi.el
+++ b/lisp/cedet/semantic/texi.el
@@ -413,7 +413,7 @@ semantic-texi-command-completion-list
   "List of commands that we might bother completing.")
 
 (define-mode-local-override semantic-analyze-possible-completions
-  texinfo-mode (context)
+  texinfo-mode (context &rest flags)
   "List smart completions at point.
 Since texinfo is not a programming language the default version is not
 useful.  Instead, look at the current symbol.  If it is a command