From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: master adfcc17: * lisp/vc/vc-dir.el: Commands to mark un/registered files (bug#34949) Date: Sat, 4 Apr 2020 17:51:53 -0700 (PDT) Message-ID: <52a199f7-919f-4dd0-8c94-25e6b0cf7ea5@default> References: <20200402220815.6555.35405@vcs0.savannah.gnu.org> <20200402220817.0DD6F20CDD@vcs0.savannah.gnu.org> <6f68379d-225d-e3bd-ef22-8e307eacdeb4@yandex.ru> <874ktybzss.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="126619"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , emacs-devel@gnu.org To: Juri Linkov , Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 05 02:52:41 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jKtWh-000Wqk-JD for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Apr 2020 02:52:39 +0200 Original-Received: from localhost ([::1]:43506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKtWg-0001nX-Kr for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Apr 2020 20:52:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52459) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKtWA-0001FK-Az for emacs-devel@gnu.org; Sat, 04 Apr 2020 20:52:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKtW8-000630-9z for emacs-devel@gnu.org; Sat, 04 Apr 2020 20:52:05 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:53836) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jKtW8-00061p-1f for emacs-devel@gnu.org; Sat, 04 Apr 2020 20:52:04 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0350juNQ136957; Sun, 5 Apr 2020 00:52:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=ZSBEtPjWGOMUCpSJjn++UKkYwjFc/oy264c2mkVBbkM=; b=OKsgyu30b6m02/sScCO0+4F4KNdVpSE+ecZLAxPJjXWiOsjSvqBuRaXZZE9/MGE5Jz3q Su7OMH6CBQtbhc2Mx8DUkfkKrGpcOmwzIe9bJTk6iQIuCIQrYnRFgAgM1mA2kadxSEpX Yu5Khqx+scLVppTJ4sEZgc13Afda6B5mx7WackTZtJ/U1yIjtff349HmOTgCoAP1klT6 CCR1zArn5EMDR59g1Baa5kaQohHuUQA85TpMSyLR4WSmbAxUItE9wz2iyT3RhLq0piV0 1kCCcknse7W6sWboplWyJSdSetAnBMQSrhi8kLmjBCWS0HjyAXo19SAc2eWjewEC5OuK FA== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 306j6m1xvk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 05 Apr 2020 00:52:00 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0350h7sO078094; Sun, 5 Apr 2020 00:52:00 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 3073q9d1t3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 05 Apr 2020 00:51:59 +0000 Original-Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0350psdF010131; Sun, 5 Apr 2020 00:51:55 GMT In-Reply-To: <874ktybzss.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4966.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9581 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 adultscore=0 malwarescore=0 suspectscore=18 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004050005 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9581 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 suspectscore=18 lowpriorityscore=0 malwarescore=0 impostorscore=0 mlxscore=0 phishscore=0 adultscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004050005 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 141.146.126.78 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246434 Archived-At: > '* u' was not added because Drew opposed on the ground that it will > conflict with the same keybinding in Dired where it is bound to > 'dired-unmark'. I gave reasons for not conflicting with Dired bindings, if VC Dired is derived from Dired, and especially if such bindings make sense also for VC Dired. But there can be other, opposing reasons to repurpose a given Dired binding, again especially if the Dired binding is not so useful in VC Dired. There's no hard and fast rule, IMO. Such things are judgment calls, after weighing pros & cons. It's you who should decide what to do here, for VC Dired.