From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: unnecessary requirement of X11 for imagemagick in case of cygwin Date: Thu, 13 Feb 2014 22:10:45 -0500 Message-ID: <52FD8935.8010105@cornell.edu> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1392347468 16831 80.91.229.3 (14 Feb 2014 03:11:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 14 Feb 2014 03:11:08 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 14 04:11:13 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WE9BI-0007zn-32 for ged-emacs-devel@m.gmane.org; Fri, 14 Feb 2014 04:11:12 +0100 Original-Received: from localhost ([::1]:49563 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WE9BH-0002fF-7e for ged-emacs-devel@m.gmane.org; Thu, 13 Feb 2014 22:11:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WE9B8-0002ex-1z for emacs-devel@gnu.org; Thu, 13 Feb 2014 22:11:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WE9B1-0003Fw-AH for emacs-devel@gnu.org; Thu, 13 Feb 2014 22:11:02 -0500 Original-Received: from limerock04.mail.cornell.edu ([128.84.12.60]:56824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WE9B1-0003FA-6F for emacs-devel@gnu.org; Thu, 13 Feb 2014 22:10:55 -0500 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id s1E3AnPP019627 for ; Thu, 13 Feb 2014 22:10:50 -0500 Original-Received: from [192.168.1.5] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id s1E3AmGI026760 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Thu, 13 Feb 2014 22:10:49 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 128.84.12.60 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:169594 Archived-At: On 2/13/2014 10:52 AM, Mirek Kaim wrote: > i've just compiled the latest version from repo under cygwin. imagemagick installed from cygwin package, with all dependecies - that includes some X-libs, but no X server per se. emacs configured --with-w32. all i did was this: > > diff --git a/configure.ac b/configure.ac > index 326d528..bc95daa 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -2236,7 +2236,7 @@ if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes" > fi > > HAVE_IMAGEMAGICK=no > -if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"; then > +#if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"; then > if test "${with_imagemagick}" != "no"; then > ## 6.2.8 is the earliest version known to work, but earlier versions > ## might work - let us know if you find one. > @@ -2254,7 +2254,7 @@ if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes" > AC_CHECK_FUNCS(MagickExportImagePixels MagickMergeImageLayers) > fi > fi > -fi > +#fi > > > HAVE_GTK=no > > and it works, checked with image-dired and pdf page scaling. obviously, imagemagick is independent from the actual gui used by emacs - as long as there is a gui, it makes sense to link with it. shouldn't it be then: > > if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes" || test "${HAVE_W32}" = "yes"; then > > or am i missing something? i'm not too familiar with configure and makefile stuff, and i never submitted a patch so i don't have an account, so feel free to patch that. This looks right to me, but I don't know enough about imagemagick to be able to test it thoroughly. Maybe some imagemagick expert could comment. In the meantime, I suggest you resend this as a bug report so it doesn't get forgotten. Ken