From: "Andreas Röhler" <andreas.roehler@easy-emacs.de>
To: Eli Zaretskii <eliz@gnu.org>, Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 16731@debbugs.gnu.org
Subject: bug#16731: 24.3.50; Latin small letter sharp s is not considered lower-case
Date: Thu, 13 Feb 2014 19:02:08 +0100 [thread overview]
Message-ID: <52FD08A0.1070300@easy-emacs.de> (raw)
In-Reply-To: <83r476rjyf.fsf@gnu.org>
Am 13.02.2014 18:39, schrieb Eli Zaretskii:
>> From: Stefan Monnier <monnier@iro.umontreal.ca>
>> Cc: andreas.roehler@easy-emacs.de, 16731@debbugs.gnu.org
>> Date: Thu, 13 Feb 2014 12:10:49 -0500
>>
>>> /* True if C is upper case. */
>>> -INLINE bool uppercasep (int c) { return downcase (c) != c; }
>>> +INLINE bool uppercasep (int c)
>>> +{
>>> + Lisp_Object val;
>>> +
>>> + if (downcase (c) != c)
>>> + return true;
>>> +
>>> + if (NILP (Vunicode_category_table))
>>> + return false;
>>> +
>>> + val = CHAR_TABLE_REF (Vunicode_category_table, c);
>>> + return INTEGERP (val) && XINT (val) == UNICODE_CATEGORY_Lu;
>>> +}
>>
>> Doesn't sound too bad. But it does beg the question: why check
>> (downcase (c) != c) at all, then?
>
> Because it's faster, and for most characters will do the job.
>
Maybe I'm missing the point: all change needed is not to store "ß" into the uppercase-table.
Why not store nil there instead?
next prev parent reply other threads:[~2014-02-13 18:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 17:29 bug#16731: 24.3.50; Latin small letter sharp s is not considered lower-case Jorgen Schaefer
2014-02-12 17:55 ` Glenn Morris
2014-02-12 19:31 ` Andreas Röhler
2014-02-12 19:49 ` Eli Zaretskii
2014-02-12 20:10 ` Andreas Röhler
2014-02-12 20:16 ` Eli Zaretskii
2014-02-12 20:33 ` Andreas Röhler
2014-02-12 20:57 ` Juanma Barranquero
2014-02-13 3:46 ` Eli Zaretskii
2014-02-13 8:27 ` Andreas Röhler
2014-02-13 15:53 ` Eli Zaretskii
2014-02-13 13:37 ` Stefan Monnier
2014-02-13 16:33 ` Eli Zaretskii
2014-02-13 17:10 ` Stefan Monnier
2014-02-13 17:39 ` Eli Zaretskii
2014-02-13 18:02 ` Andreas Röhler [this message]
2014-02-13 18:17 ` Eli Zaretskii
2014-02-13 18:10 ` Stefan Monnier
2014-02-13 18:16 ` Eli Zaretskii
2014-02-13 19:15 ` Stefan Monnier
2014-02-13 20:24 ` Eli Zaretskii
2014-02-14 17:22 ` Stefan Monnier
2014-02-14 18:16 ` Eli Zaretskii
2014-02-14 20:59 ` Stefan Monnier
2014-02-15 7:12 ` Eli Zaretskii
2014-02-17 3:09 ` Stefan Monnier
2014-02-17 5:29 ` Eli Zaretskii
2014-02-13 17:58 ` Juanma Barranquero
2014-02-13 18:18 ` Eli Zaretskii
2014-02-13 18:22 ` Juanma Barranquero
2014-02-13 18:47 ` Glenn Morris
2014-02-13 20:16 ` Eli Zaretskii
2014-02-14 16:20 ` bug#16731: 24.3.50; , " Paul Eggert
2021-07-16 12:32 ` bug#10576: Subject: 23.4; char class [:lower:] misses latin small letter sharp s Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FD08A0.1070300@easy-emacs.de \
--to=andreas.roehler@easy-emacs.de \
--cc=16731@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.