bug#16649: Right margin overflows on neighboring windows.

bug#16649: Right margin overflows on neighboring windows.

[E Sabof]

From emacs -Q, with version from trunk.

STEPS:

(set-window-margins nil (car (window-margins)) 30))
C-x 3

Resize, until the right window is smaller than the margin.

RESULT:

The right window's right fringe will be drawn on top of the left window's right margin.

Evgeni

GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.6.4) of 2014-02-05 on ubuntu

bug#16649: Right margin overflows on neighboring windows.

[martin rudalics]

 >>From emacs -Q, with version from trunk.
 >
 > STEPS:
 >
 > (set-window-margins nil (car (window-margins)) 30))
 > C-x 3
 >
 > Resize, until the right window is smaller than the margin.
 >
 > RESULT:
 >
 > The right window's right fringe will be drawn on top of the left window's right margin.

Should be fixed now.  Though using such large margins surely means
asking for trouble.

Thanks, martin

bug#16649: Right margin overflows on neighboring windows.

[E Sabof]

Works indeed, thanks!

Evgeni

martin rudalics <rudalics@gmx.at> writes:

>  >>From emacs -Q, with version from trunk.
>  >
>  > STEPS:
>  >
>  > (set-window-margins nil (car (window-margins)) 30))
>  > C-x 3
>  >
>  > Resize, until the right window is smaller than the margin.
>  >
>  > RESULT:
>  >
>  > The right window's right fringe will be drawn on top of the left window's right margin.
>
> Should be fixed now.  Though using such large margins surely means
> asking for trouble.
>
> Thanks, martin

bug#16649: Right margin overflows on neighboring windows.

[E Sabof]

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]

Sorry, the right fringe renders correctly, but the margin still overflows. Attached is a screenshot of magit-log, where this can be seen. Below is a test case.

Evgeni

(let ((ov (make-overlay (point-min) (point-max))))
  (overlay-put ov
               'before-string
               (propertize "o" 'display
                           (list '(margin right-margin)
                                 (propertize
                                  "Laetamur quis quam, aliqua nostrum."
                                  'face '(:background "yellow")
                                  ))))
  (set-window-margins nil (car (window-margins)) 30))


[-- Attachment #2: 2014-02-07-022045_707x630_scrot.png --]
[-- Type: image/png, Size: 196032 bytes --]

[-- Attachment #3: Type: text/plain, Size: 569 bytes --]


E Sabof <esabof@gmail.com> writes:

> Works indeed, thanks!
>
> Evgeni
>
> martin rudalics <rudalics@gmx.at> writes:
>
>>  >>From emacs -Q, with version from trunk.
>>  >
>>  > STEPS:
>>  >
>>  > (set-window-margins nil (car (window-margins)) 30))
>>  > C-x 3
>>  >
>>  > Resize, until the right window is smaller than the margin.
>>  >
>>  > RESULT:
>>  >
>>  > The right window's right fringe will be drawn on top of the left window's right margin.
>>
>> Should be fixed now.  Though using such large margins surely means
>> asking for trouble.
>>
>> Thanks, martin

bug#16649: Right margin overflows on neighboring windows.

[Eli Zaretskii]

> From: E Sabof <esabof@gmail.com>
> Date: Fri, 07 Feb 2014 02:45:15 +0000
> Cc: 16649@debbugs.gnu.org
> 
> Sorry, the right fringe renders correctly, but the margin still overflows. Attached is a screenshot of magit-log, where this can be seen. Below is a test case.
> 
> Evgeni
> 
> (let ((ov (make-overlay (point-min) (point-max))))
>   (overlay-put ov
>                'before-string
>                (propertize "o" 'display
>                            (list '(margin right-margin)
>                                  (propertize
>                                   "Laetamur quis quam, aliqua nostrum."
>                                   'face '(:background "yellow")
>                                   ))))
>   (set-window-margins nil (car (window-margins)) 30))

Could you please tell what exactly is wrong with display in the above
test case?  And what does "the margin overflows" mean?  Maybe I'm
blind, but I don't see anything wrong when I eval the above code.

As for the magit display, it is so loaded with stuff that it is hard
to even know where's the margin there.  So please tell where to look
and what is it that you think is wrong in that screenshot.

Thanks.

bug#16649: Right margin overflows on neighboring windows.

[martin rudalics]

 > Sorry, the right fringe renders correctly, but the margin still overflows. Attached is a screenshot of magit-log, where this can be seen. Below is a test case.
 >
 > Evgeni
 >
 > (let ((ov (make-overlay (point-min) (point-max))))
 >   (overlay-put ov
 >                'before-string
 >                (propertize "o" 'display
 >                            (list '(margin right-margin)
 >                                  (propertize
 >                                   "Laetamur quis quam, aliqua nostrum."
 >                                   'face '(:background "yellow")
 >                                   ))))
 >   (set-window-margins nil (car (window-margins)) 30))

OK.  Please try again.

martin

bug#16649: Right margin overflows on neighboring windows.

[martin rudalics]

 > Could you please tell what exactly is wrong with display in the above
 > test case?  And what does "the margin overflows" mean?  Maybe I'm
 > blind, but I don't see anything wrong when I eval the above code.

You have to do C-x 3 and enlarge one of the windows to see the effects.
There were plenty of them - mostly related to not returning the right
values via window box related functions.  I also now adjust the window
margins when a window gets to narrow because otherwise the redisplay
engine gets confused when inserting new text.  Still pretty toothless
when confronted with more drastic specifications but the best I came up
with so far.

martin

bug#16649: Right margin overflows on neighboring windows.

[Eli Zaretskii]

> Date: Fri, 07 Feb 2014 12:14:11 +0100
> From: martin rudalics <rudalics@gmx.at>
> CC: E Sabof <esabof@gmail.com>, 16649@debbugs.gnu.org
> 
>  > Could you please tell what exactly is wrong with display in the above
>  > test case?  And what does "the margin overflows" mean?  Maybe I'm
>  > blind, but I don't see anything wrong when I eval the above code.
> 
> You have to do C-x 3 and enlarge one of the windows to see the effects.

I did, and still didn't see any problems.

Anyway, thanks for taking care of this.

> There were plenty of them - mostly related to not returning the right
> values via window box related functions.  I also now adjust the window
> margins when a window gets to narrow because otherwise the redisplay
> engine gets confused when inserting new text.  Still pretty toothless
> when confronted with more drastic specifications but the best I came up
> with so far.

Any mode that gets to these extreme situations should be shot through
the head.

bug#16649: Right margin overflows on neighboring windows.

[martin rudalics]

>> You have to do C-x 3 and enlarge one of the windows to see the effects.
> 
> I did, and still didn't see any problems.

On Windows, whose redisplay is sometimes better than GTK's ;-)

martin

bug#16649: Right margin overflows on neighboring windows.

[martin rudalics]

>  > Sorry, the right fringe renders correctly, but the margin still 
> overflows. Attached is a screenshot of magit-log, where this can be 
> seen. Below is a test case.

Is this fixed now?

martin

bug#16649: Right margin overflows on neighboring windows.

[E Sabof]

martin rudalics <rudalics@gmx.at> writes:

>>  > Sorry, the right fringe renders correctly, but the margin still
>> overflows. Attached is a screenshot of magit-log, where this can be
>> seen. Below is a test case.
>
> Is this fixed now?
>
> martin

Yes, it's fixed, thanks!

Evgeni