all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* suggestion: blue default for new face `window-divider'
@ 2014-01-30 19:48 Drew Adams
  2014-01-31  1:05 ` Michael Heerdegen
  0 siblings, 1 reply; 6+ messages in thread
From: Drew Adams @ 2014-01-30 19:48 UTC (permalink / raw)
  To: emacs-devel

Subject line says it all.  Consider making the window divider more
noticeable by making it a blue line - same color as links (active).

(I'd also suggest that the default width of window dividers be 2,
not zero, also to make it more noticeable.)



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: suggestion: blue default for new face `window-divider'
  2014-01-30 19:48 suggestion: blue default for new face `window-divider' Drew Adams
@ 2014-01-31  1:05 ` Michael Heerdegen
  2014-01-31  9:16   ` Juri Linkov
  2014-01-31 10:42   ` martin rudalics
  0 siblings, 2 replies; 6+ messages in thread
From: Michael Heerdegen @ 2014-01-31  1:05 UTC (permalink / raw)
  To: emacs-devel

Drew Adams <drew.adams@oracle.com> writes:

> Subject line says it all.  Consider making the window divider more
> noticeable by making it a blue line - same color as links (active).

I tried this, but found it distracting.  Once you know it's there, it
must not be that "shining".  I use grey40 now.

> (I'd also suggest that the default width of window dividers be 2,
> not zero, also to make it more noticeable.)

Or at least one, so that you get a different cursor when hovering over
that area, and recognize that resizing is possible.

OTOH, I can understand why the size is 0 when scroll bars are used: It
can happen that you click on the scroll bar by mistake.  In my
installation it is especially problematic that the mouse cursor change
is not correct for me: I get the "dragging" cursor in a stripe wider
than the window divider.  That makes it very likely to click the scroll
bar by mistake.

Michael.




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: suggestion: blue default for new face `window-divider'
  2014-01-31  1:05 ` Michael Heerdegen
@ 2014-01-31  9:16   ` Juri Linkov
  2014-01-31 10:43     ` martin rudalics
  2014-01-31 10:42   ` martin rudalics
  1 sibling, 1 reply; 6+ messages in thread
From: Juri Linkov @ 2014-01-31  9:16 UTC (permalink / raw)
  To: Michael Heerdegen; +Cc: emacs-devel

>> Subject line says it all.  Consider making the window divider more
>> noticeable by making it a blue line - same color as links (active).
>
> I tried this, but found it distracting.  Once you know it's there, it
> must not be that "shining".  I use grey40 now.

The face `vertical-border' inherits from `mode-line-inactive'
which is grey by default, so `window-divider' could do the same.

PS: I don't understand why there are two identical faces
`vertical-border' and `window-divider'.

With no scroll bars, evaluating

  (set-frame-parameter (selected-frame) 'right-divider-width 0)

uses the `vertical-border' face, and allows resizing windows
by dragging the vertical line.

And after

  (set-frame-parameter (selected-frame) 'right-divider-width 1)

`vertical-border' is replaced by `window-divider' with exactly
the same behavior.  Shouldn't these faces be merged?



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: suggestion: blue default for new face `window-divider'
  2014-01-31  1:05 ` Michael Heerdegen
  2014-01-31  9:16   ` Juri Linkov
@ 2014-01-31 10:42   ` martin rudalics
  1 sibling, 0 replies; 6+ messages in thread
From: martin rudalics @ 2014-01-31 10:42 UTC (permalink / raw)
  To: Michael Heerdegen; +Cc: emacs-devel

 >> (I'd also suggest that the default width of window dividers be 2,
 >> not zero, also to make it more noticeable.)
 >
 > Or at least one, so that you get a different cursor when hovering over
 > that area, and recognize that resizing is possible.
 >
 > OTOH, I can understand why the size is 0 when scroll bars are used: It
 > can happen that you click on the scroll bar by mistake.  In my
 > installation it is especially problematic that the mouse cursor change
 > is not correct for me: I get the "dragging" cursor in a stripe wider
 > than the window divider.  That makes it very likely to click the scroll
 > bar by mistake.

We should follow general practice here and make the default at least 4
pixels, probably 6.  That's what I see on Thunderbird, for example.  The
value 0 means only that by default dividers are not drawn.

martin



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: suggestion: blue default for new face `window-divider'
  2014-01-31  9:16   ` Juri Linkov
@ 2014-01-31 10:43     ` martin rudalics
  2014-01-31 15:38       ` Drew Adams
  0 siblings, 1 reply; 6+ messages in thread
From: martin rudalics @ 2014-01-31 10:43 UTC (permalink / raw)
  To: Juri Linkov; +Cc: Michael Heerdegen, emacs-devel

 > The face `vertical-border' inherits from `mode-line-inactive'
 > which is grey by default, so `window-divider' could do the same.

IMHO the default should imitate the standard 3D effect generally used
for window dividers.  Unfortunately, doing that without prior knowledge
of the respective API primitives is tedious.  It would be a great help
if anyone else could do that.

 > PS: I don't understand why there are two identical faces
 > `vertical-border' and `window-divider'.
 >
 > With no scroll bars, evaluating
 >
 >   (set-frame-parameter (selected-frame) 'right-divider-width 0)
 >
 > uses the `vertical-border' face, and allows resizing windows
 > by dragging the vertical line.
 >
 > And after
 >
 >   (set-frame-parameter (selected-frame) 'right-divider-width 1)
 >
 > `vertical-border' is replaced by `window-divider' with exactly
 > the same behavior.  Shouldn't these faces be merged?

I didn't want to change existing code, so I left `vertical-border'
untouched.  The divider face is used for horizontal dividers as well, so
the name vertical-border would be inappropriate.

Finally, I'm not yet sure how to incorporate the default 3D value
mentioned above in the face definition.

martin



^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: suggestion: blue default for new face `window-divider'
  2014-01-31 10:43     ` martin rudalics
@ 2014-01-31 15:38       ` Drew Adams
  0 siblings, 0 replies; 6+ messages in thread
From: Drew Adams @ 2014-01-31 15:38 UTC (permalink / raw)
  To: martin rudalics, Juri Linkov; +Cc: Michael Heerdegen, emacs-devel

> Finally, I'm not yet sure how to incorporate the default 3D value
> mentioned above in the face definition.

If the how for implementing this gets figured out, perhaps the
user control over it could make use of face attribute `box',
which allows for raised and sunken styles?  IOW, maybe let users
choose the 3D effect by choosing a box with raised style.

Just a thought, as I guess there are two parts to "how to
incorporate ... into the face definition", one part being how
users would choose 3D.

Currently it seems (at least on Windows) that the only attribute
that has an effect is the foreground.  When this face is fully
baked, the doc string should let users know which attributes
have an effect.



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-01-31 15:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-30 19:48 suggestion: blue default for new face `window-divider' Drew Adams
2014-01-31  1:05 ` Michael Heerdegen
2014-01-31  9:16   ` Juri Linkov
2014-01-31 10:43     ` martin rudalics
2014-01-31 15:38       ` Drew Adams
2014-01-31 10:42   ` martin rudalics

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.