Re: Changes in update-game-score.c

[Paul Eggert <eggert@cs.ucla.edu>]

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

Eli Zaretskii wrote:
> sumo changesets make maintenance harder

Sure, but the change that prompted this thread (trunk bzr 116113) 
deleted 13 lines of code and added 8. That's a small changeset, not a 
sumo one.

> the comparison is invalid because this [other] change wasn't fixing any bug, it's more like whitespace cleanup.

It's easy to find bug-fixing changes that behave the same way. For 
example, the most recent bug-fixing patch that you installed (attached) 
actually consists of multiple independent changes. One change replaces 
fchmod with chmod on WINDOWSNT platforms, fixing a porting bug; but 
another change replaces "!=" with "<" on WINDOWSNT, and this change does 
not fix any bug.

This sort of thing happens all the time, and it's OK. It'd be 
unreasonable to insist that every patch to Emacs now must fix just one 
bug and must not make any changes that do not fix the bug.


[-- Attachment #2: w32.diff --]
[-- Type: text/x-patch, Size: 939 bytes --]

=== modified file 'lib-src/ChangeLog'
--- lib-src/ChangeLog	2014-01-22 19:02:41 +0000
+++ lib-src/ChangeLog	2014-01-22 19:38:31 +0000
@@ -1,3 +1,8 @@
+2014-01-22  Eli Zaretskii  <eliz@gnu.org>
+
+	* update-game-score.c (write_scores) [WINDOWSNT]: Use chmod
+	instead of fchmod.
+
 2014-01-22  Paul Eggert  <eggert@cs.ucla.edu>
 
 	Fix miscellaneous update-game-score bugs.

=== modified file 'lib-src/update-game-score.c'
--- lib-src/update-game-score.c	2014-01-22 19:02:41 +0000
+++ lib-src/update-game-score.c	2014-01-22 19:38:31 +0000
@@ -443,8 +443,10 @@
   fd = mkostemp (tempfile, 0);
   if (fd < 0)
     return -1;
+#ifndef WINDOWSNT
   if (fchmod (fd, 0644) != 0)
     return -1;
+#endif
   f = fdopen (fd, "w");
   if (! f)
     return -1;
@@ -457,6 +459,10 @@
     return -1;
   if (rename (tempfile, filename) != 0)
     return -1;
+#ifdef WINDOWSNT
+  if (chmod (filename, 0644) < 0)
+    return -1;
+#endif
   return 0;
 }