From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Changes in update-game-score.c Date: Thu, 23 Jan 2014 13:50:56 -0800 Organization: UCLA Computer Science Department Message-ID: <52E18EC0.7090302@cs.ucla.edu> References: <8361pbg5vy.fsf@gnu.org> <52E08D31.3080801@cs.ucla.edu> <8338kffj7m.fsf@gnu.org> <52E0A0ED.4020601@cs.ucla.edu> <83y526el6z.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------080307080405050400050202" X-Trace: ger.gmane.org 1390513869 10029 80.91.229.3 (23 Jan 2014 21:51:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 23 Jan 2014 21:51:09 +0000 (UTC) Cc: Emacs developers To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 23 22:51:15 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W6SB8-0005sL-JN for ged-emacs-devel@m.gmane.org; Thu, 23 Jan 2014 22:51:14 +0100 Original-Received: from localhost ([::1]:43362 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6SB8-0004S6-6L for ged-emacs-devel@m.gmane.org; Thu, 23 Jan 2014 16:51:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6SAy-0004Gz-VV for emacs-devel@gnu.org; Thu, 23 Jan 2014 16:51:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6SAt-0002XL-3q for emacs-devel@gnu.org; Thu, 23 Jan 2014 16:51:04 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:33002) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6SAs-0002X8-IM for emacs-devel@gnu.org; Thu, 23 Jan 2014 16:50:58 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 6590539E8011; Thu, 23 Jan 2014 13:50:57 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jbcOIiq3778G; Thu, 23 Jan 2014 13:50:56 -0800 (PST) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id AC2A939E8008; Thu, 23 Jan 2014 13:50:56 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168983 Archived-At: This is a multi-part message in MIME format. --------------080307080405050400050202 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/23/2014 12:27 PM, Juanma Barranquero wrote: > On Thu, Jan 23, 2014 at 5:07 PM, Eli Zaretskii wrote: > >> >That is exactly what we all should do: each commit is one coherent >> >changeset, solving a problem that is independent of others. > Very emphatically agree. It's easy to nod one's head and say "yes, that's right! and whoever commits independent changes should be taken out and shot!". But in practice that's far too extreme. For example, if we look at a recent simple patch (attached), it's actually two changes, one change for each variable that was declared on WINDOWSNT platforms but not used there. Now, suppose someone complained "Hey! Wait a minute! You should have broken that into two independent fixes and installed each fix separately!" I hope our response would be something like "Sure, we could have installed two separate patches. But that would have been overkill here; it would have been too much work for everybody for too little benefit." The situation for update-game-score was similar, and this is true of many changes we make to Emacs. --------------080307080405050400050202 Content-Type: text/x-patch; name="windowsnt.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="windowsnt.diff" === modified file 'src/ChangeLog' --- src/ChangeLog 2013-12-30 17:51:28 +0000 +++ src/ChangeLog 2013-12-30 22:36:44 +0000 @@ -1,3 +1,8 @@ +2013-12-30 Juanma Barranquero + + * fileio.c (Fcopy_file) [!WINDOWSNT]: Don't declare on Windows + variables not used there. + 2013-12-30 Eli Zaretskii * w32.c (sys_umask): New function. (Bug#16299) === modified file 'src/fileio.c' --- src/fileio.c 2013-12-29 18:18:45 +0000 +++ src/fileio.c 2013-12-30 22:36:44 +0000 @@ -1943,15 +1943,15 @@ struct gcpro gcpro1, gcpro2, gcpro3, gcpro4; ptrdiff_t count = SPECPDL_INDEX (); Lisp_Object encoded_file, encoded_newname; +#if HAVE_LIBSELINUX + security_context_t con; + int conlength = 0; +#endif +#ifdef WINDOWSNT + int result; +#else bool already_exists = false; mode_t new_mask; -#if HAVE_LIBSELINUX - security_context_t con; - int conlength = 0; -#endif -#ifdef WINDOWSNT - int result; -#else int ifd, ofd; int n; char buf[16 * 1024]; --------------080307080405050400050202--