From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Changes in update-game-score.c Date: Wed, 22 Jan 2014 19:32:01 -0800 Organization: UCLA Computer Science Department Message-ID: <52E08D31.3080801@cs.ucla.edu> References: <8361pbg5vy.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1390447944 5678 80.91.229.3 (23 Jan 2014 03:32:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 23 Jan 2014 03:32:24 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 23 04:32:30 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W6B1q-0006Tz-B1 for ged-emacs-devel@m.gmane.org; Thu, 23 Jan 2014 04:32:30 +0100 Original-Received: from localhost ([::1]:38718 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6B1p-0000zu-PL for ged-emacs-devel@m.gmane.org; Wed, 22 Jan 2014 22:32:29 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6B1f-0000yh-GW for emacs-devel@gnu.org; Wed, 22 Jan 2014 22:32:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6B1Y-0000WO-7r for emacs-devel@gnu.org; Wed, 22 Jan 2014 22:32:19 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:41015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6B1Q-0000UN-G9; Wed, 22 Jan 2014 22:32:04 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 94B77A60003; Wed, 22 Jan 2014 19:32:02 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MVfB50uvltKY; Wed, 22 Jan 2014 19:32:02 -0800 (PST) Original-Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 0822AA60002; Wed, 22 Jan 2014 19:32:02 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 In-Reply-To: <8361pbg5vy.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168925 Archived-At: Eli Zaretskii wrote: > Why do we suddenly care about it so much? We got a bug report about it, which I fixed, and I noticed some other bugs in the neighborhood, including undefined behavior and race conditions which are dicey in a setuid program (it's bad PR at the very least). A feature freeze shouldn't prevent us from fixing such bugs. The main culprit here was the w32 port's definition of fchmod as a noop for Emacs, and its failure to define fchmod for non-Emacs executables. We can't expect non-w32 experts to anticipate that sort of tricky situation flawlessly every time.