all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Antipov <dmantipov@yandex.ru>
To: Emacs development discussions <emacs-devel@gnu.org>
Cc: Stefan Monnier <monnier@IRO.UMontreal.CA>
Subject: Buffer/window/frame redisplay bit
Date: Mon, 20 Jan 2014 15:42:00 +0400	[thread overview]
Message-ID: <52DD0B88.1090606@yandex.ru> (raw)

I've noticed that windows are created with zero redisplay bit, new
frames has this bit set, but buffer texts leaves them uninitialized.
This is sometimes shown by valgrind, for example:

==15146== Conditional jump or move depends on uninitialised value(s)
==15146==    at 0x45D7A0: propagate_buffer_redisplay (xdisp.c:13153)
==15146==    by 0x45EC14: redisplay_internal (xdisp.c:13608)
==15146==    by 0x45CB74: redisplay (xdisp.c:12919)
==15146==    by 0x56BECA: read_char (keyboard.c:2563)
==15146==    by 0x57B32F: read_key_sequence (keyboard.c:9071)
==15146==    by 0x568EF0: command_loop_1 (keyboard.c:1445)
==15146==    by 0x608602: internal_condition_case (eval.c:1345)
==15146==    by 0x5687CC: command_loop_2 (keyboard.c:1170)
==15146==    by 0x607A85: internal_catch (eval.c:1109)
==15146==    by 0x568780: command_loop (keyboard.c:1149)
==15146==    by 0x567E30: recursive_edit_1 (keyboard.c:777)
==15146==    by 0x568000: Frecursive_edit (keyboard.c:841)

IMO b->text->redisplay should be initialized in Fget_buffer_create, but
I have no representative test case to decide whether it should be 0 or 1.

Dmitry



             reply	other threads:[~2014-01-20 11:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-20 11:42 Dmitry Antipov [this message]
2014-01-20 13:52 ` Buffer/window/frame redisplay bit Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52DD0B88.1090606@yandex.ru \
    --to=dmantipov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.