From: Dmitry Antipov <dmantipov@yandex.ru>
To: "K. Handa" <handa@gnu.org>
Cc: 16457@debbugs.gnu.org
Subject: bug#16457: 24.3.50; crash rendering Arabic Uthmani script
Date: Sun, 19 Jan 2014 20:00:46 +0400 [thread overview]
Message-ID: <52DBF6AE.3040902@yandex.ru> (raw)
In-Reply-To: <87r484krul.fsf@gnu.org>
On 01/19/2014 05:45 PM, K. Handa wrote:
> But, by checking my latest change again, I noticed a silly
> mistake :-(, and just installed the following patch.
>
> === modified file 'src/composite.c'
> --- src/composite.c 2014-01-12 23:23:55 +0000
> +++ src/composite.c 2014-01-19 13:24:59 +0000
> @@ -1412,7 +1412,7 @@
> cmp_it->width = 0;
> for (i = cmp_it->nchars - 1; i >= 0; i--)
> {
> - c = XINT (LGSTRING_CHAR (gstring, cmp_it->from + i));
> + c = XINT (LGSTRING_CHAR (gstring, from + i));
> cmp_it->nbytes += CHAR_BYTES (c);
> cmp_it->width += CHAR_WIDTH (c);
> }
>
> Coud you please try agian with the latest trunk code?
Now it doesn't crash, and column number looks correct. Thanks.
Dmitry
prev parent reply other threads:[~2014-01-19 16:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 17:24 bug#16457: 24.3.50; crash rendering Arabic Uthmani script Dmitry Antipov
2014-01-15 17:41 ` Eli Zaretskii
2014-01-15 21:44 ` Glenn Morris
2014-01-16 8:01 ` Dmitry Antipov
2014-01-16 10:07 ` Dmitry Antipov
2014-01-16 17:33 ` Eli Zaretskii
2014-01-16 17:33 ` Eli Zaretskii
2014-01-17 7:34 ` Dmitry Antipov
2014-01-17 9:10 ` Eli Zaretskii
2014-01-17 11:16 ` Dmitry Antipov
2014-01-17 12:03 ` Eli Zaretskii
2014-01-17 13:51 ` K. Handa
2014-01-19 13:45 ` K. Handa
2014-01-19 16:00 ` Dmitry Antipov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DBF6AE.3040902@yandex.ru \
--to=dmantipov@yandex.ru \
--cc=16457@debbugs.gnu.org \
--cc=handa@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.