From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>, esr@thyrsus.com
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: The fixes-bug field
Date: Thu, 16 Jan 2014 23:58:23 -0800 [thread overview]
Message-ID: <52D8E29F.6040004@cs.ucla.edu> (raw)
In-Reply-To: <83sisn12sk.fsf@gnu.org>
Eli Zaretskii wrote:
> If this information will be in the commit message (one suggestion so
> far, AFAIU), we should define its precise format and location within
> the commit message.
Let's define the format that we're already using in ChangeLog entries.
That is, a commit message that contains the string "Bug#16372" is
related to Bug#16372. This would be simpler and more natural than
what we're doing now.
For example, with bzr, this ChangeLog entry:
2014-01-07 Paul Eggert <eggert@cs.ucla.edu>
Fix misdisplay of interlaced GIFs with libgif5 (Bug#16372).
* image.c (gif_load): libgif5 deinterlaces for us, so don't do
it again.
corresponds to this commit message in trunk bzr 115915:
Fix misdisplay of interlaced GIFs with libgif5.
* image.c (gif_load): libgif5 deinterlaces for us, so don't do
it again.
and means that the change is related to Bug#16372.
With git, I'd prefer using a commit message that matches what's in
the ChangeLog entry, as that's simpler anyway. I.e., I'd rather use
this commit message:
Fix misdisplay of interlaced GIFs with libgif5 (Bug#16372).
* image.c (gif_load): libgif5 deinterlaces for us, so don't do
it again.
This way, I could use vanilla vc-dwim to check in my changes,
rather the current song and dance where the commit message doesn't
quite match the ChangeLog entry (as the Bug# is missing)
and I run bzr with the --fixes option to communicate the Bug#.
next prev parent reply other threads:[~2014-01-17 7:58 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 14:13 The fixes-bug field Eric S. Raymond
2014-01-16 16:13 ` Stefan Monnier
2014-01-16 16:30 ` Eric S. Raymond
2014-01-16 16:55 ` Eli Zaretskii
2014-01-16 17:54 ` Glenn Morris
2014-01-16 18:09 ` Eric S. Raymond
2014-01-16 18:38 ` Darren Hoo
2014-01-16 19:32 ` Stefan Monnier
2014-01-16 20:06 ` Glenn Morris
2014-01-16 21:30 ` Eli Zaretskii
2014-01-16 21:24 ` Eli Zaretskii
2014-01-16 18:55 ` Paul Eggert
2014-01-16 19:13 ` Glenn Morris
2014-01-16 20:25 ` Paul Eggert
2014-01-16 18:08 ` Eric S. Raymond
2014-01-16 18:36 ` Eli Zaretskii
2014-01-16 20:04 ` Eric S. Raymond
2014-01-16 21:29 ` Eli Zaretskii
2014-01-16 21:47 ` Eric S. Raymond
2014-01-17 7:32 ` Eli Zaretskii
2014-01-17 7:58 ` Paul Eggert [this message]
2014-01-17 8:04 ` Jarek Czekalski
2014-01-17 9:21 ` Yuri Khan
2014-01-17 14:31 ` Stefan Monnier
2014-01-17 15:57 ` Lars Ingebrigtsen
2014-01-17 16:12 ` Stefan Monnier
2014-01-17 17:20 ` Lars Ingebrigtsen
2014-01-18 9:19 ` Jarek Czekalski
2014-01-18 16:02 ` Lars Ingebrigtsen
2014-01-17 13:16 ` Eric S. Raymond
2014-01-17 13:55 ` Eli Zaretskii
2014-01-17 14:26 ` Stefan Monnier
2014-01-16 17:00 ` Glenn Morris
2014-01-16 17:22 ` Achim Gratz
2014-01-16 17:57 ` Glenn Morris
-- strict thread matches above, loose matches on Subject: below --
2014-01-16 14:15 Eric S. Raymond
2014-01-16 17:11 ` Eli Zaretskii
2014-01-17 20:29 ` Eric S. Raymond
2014-01-18 7:51 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D8E29F.6040004@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=esr@thyrsus.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.