From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] About the :distant-foreground face attribute Date: Tue, 14 Jan 2014 14:14:03 -0800 Message-ID: <52D5B6AB.50109@dancol.org> References: <87bnzo9cja.fsf@gnu.org> <59B7E7FC-48D0-4737-B1BB-FFAC5BA9E07A@swipnet.se> <874n5f3162.fsf@gnu.org> <83fvozf86g.fsf@gnu.org> <87r48javwe.fsf@gnu.org> <83bnzmfjxe.fsf@gnu.org> <52D3E689.6050902@dancol.org> <8E16225F-53EF-498A-AB35-66EB9B33B859@swipnet.se> <52D43360.6050605@dancol.org> <9BD01B88-AF13-44DD-8DBE-4598BAC136DD@swipnet.se> <52D45C73.6090906@dancol.org> <52D4EBA9.8050802@swipnet.se> <52D4F2C2.8080800@dancol.org> <52D504A7.80104@swipnet.se> <52D514FF.7010404@dancol.org> <52D52312.6070106@swipnet.se> <52D58632.3010106@dancol.org> <381DEBDC-71D8-4FAC-BA55-897FEC73A2FC@swipnet.se> <52D598AF.9050306@dancol.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1389737659 26917 80.91.229.3 (14 Jan 2014 22:14:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 14 Jan 2014 22:14:19 +0000 (UTC) Cc: Eli Zaretskii , Chong Yidong , emacs-devel To: =?ISO-8859-1?Q?Jan_Dj=E4rv?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 14 23:14:24 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W3CFb-0004Ne-HR for ged-emacs-devel@m.gmane.org; Tue, 14 Jan 2014 23:14:23 +0100 Original-Received: from localhost ([::1]:50959 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3CFa-0007wT-TW for ged-emacs-devel@m.gmane.org; Tue, 14 Jan 2014 17:14:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38810) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3CFX-0007wK-3W for emacs-devel@gnu.org; Tue, 14 Jan 2014 17:14:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3CFW-0004ix-3I for emacs-devel@gnu.org; Tue, 14 Jan 2014 17:14:19 -0500 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:58202) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3CFO-0004iP-Ed; Tue, 14 Jan 2014 17:14:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=ogyHmP4uqbUtC7oX0kojuektzTnth51pbgwwjjO7QE0=; b=gsUehRXol10B/a4O8vvXYR1jrLyG6KVk1xzOy+1+nTbzJLhUYG7YqsGSFHTEcJp67HW+6H+DzO8TPpueF5wMJDvIznLUkTbeDybqGEFk3K3YgEdmDhGeYTV/frEfL/LLRpMU+3eFF0/Mxj0crO4d4oKbgN/GkmU+9oIqLfNpO0KFfo4SKpaCjc802ZcAFE82DCY1sfN2/gJMZxkrZD9/HnSifi7RhGfr+BU65/RSvTcLXND5Y9pLiRXCanELQRIjNN/KKH6v/vTK+bB2M0lV7PH8nKbvK5VBaiwV3x5NUm/f5SdmWoPs8Dmjzqmyj1g2Fx8nNb/jMw6Tnll01BH5Yw==; Original-Received: from [2620:0:1cfe:99::1] by dancol.org with esmtpsa (TLS1.0:DHE_RSA_CAMELLIA_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1W3CFN-00031E-6m; Tue, 14 Jan 2014 14:14:09 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168403 Archived-At: On 01/14/2014 02:05 PM, Jan Djärv wrote: > 14 jan 2014 kl. 21:06 skrev Daniel Colascione : > >> On 01/14/2014 12:01 PM, Jan Djärv wrote: >>> >>> No. If Emacs generates a color, Emacs desides what looks good. If >>> the system defines a color, the system (or the user if customized) >>> desides what looks good. I don't think it matters what I think about >>> colors generated by your patch, I might even think they look better >>> than many system defined colors. But as a principle I think the >>> desision is not Emacs to make *by default*. Users may of course >>> apply customizations to Emacs and change it. >> >> In 24.4, Emacs has already been changed to override the system selection foreground color with various font-lock faces. > > Which font lock faces are you talking about? No system I know of defines > system colors for things like comment face, function face etc. > >> Why is it okay to do that when there's no contrast problem, but suddenly, when there's a contrast problem, we can say that the principle of following system colors is important? > > The principle of following system foreground is only important if system > background is used. Then why don't we always use the system *selection* foreground color when we use the system *selection* background? When we apply font-lock foreground colors to a region you've highlighted, we're overriding your system's selection foreground color. Why is it okay to override that color in some situations but not others? > This is currently for NS/Gtk+ only. For Lucid/Motif/No toolkit, we don't use > system colors at all, because they are not known and can not be known, > because the API to get them is not available. > >> You're applying this principle very selectively. > > System background + contrast problem => system foreground. > How is that selectively, it is a clear rule. It's clear, but arbitrary. Another clear and arbitrary rule is this: System background + contrast problem => adjust foreground. You haven't presented any justification for your arbitrary rule being better than my arbitrary rule.