From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: About the :distant-foreground face attribute Date: Tue, 14 Jan 2014 10:31:10 -0800 Message-ID: <52D5826E.7080700@dancol.org> References: <87bnzo9cja.fsf@gnu.org> <59B7E7FC-48D0-4737-B1BB-FFAC5BA9E07A@swipnet.se> <874n5f3162.fsf@gnu.org> <83fvozf86g.fsf@gnu.org> <87r48javwe.fsf@gnu.org> <83bnzmfjxe.fsf@gnu.org> <52D3E689.6050902@dancol.org> <8E16225F-53EF-498A-AB35-66EB9B33B859@swipnet.se> <52D43360.6050605@dancol.org> <9BD01B88-AF13-44DD-8DBE-4598BAC136DD@swipnet.se> <52D45C73.6090906@dancol.org> <52D4EBA9.8050802@swipnet.se> <52D4F2C2.8080800@dancol.org> <52D504A7.80104@swipnet.se> <52D514FF.7010404@dancol.org> <52D52312.6070106@swipnet.se> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1389724288 23513 80.91.229.3 (14 Jan 2014 18:31:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 14 Jan 2014 18:31:28 +0000 (UTC) Cc: Chong Yidong , emacs-devel To: =?ISO-8859-1?Q?Jan_Dj=E4rv?= , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 14 19:31:35 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W38lz-0000Dq-7W for ged-emacs-devel@m.gmane.org; Tue, 14 Jan 2014 19:31:35 +0100 Original-Received: from localhost ([::1]:50079 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W38ly-0003kc-So for ged-emacs-devel@m.gmane.org; Tue, 14 Jan 2014 13:31:34 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W38lv-0003kV-FN for emacs-devel@gnu.org; Tue, 14 Jan 2014 13:31:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W38lu-0003YW-G3 for emacs-devel@gnu.org; Tue, 14 Jan 2014 13:31:31 -0500 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:57644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W38lr-0003Vs-PM; Tue, 14 Jan 2014 13:31:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=Su6O5tbruQ4coenRdL812gg7FI8vliOQgjZxk4G+EUc=; b=IrYe94uMHdywiNJcp0f/mWB7kJVEHX0WyJ6Q16sFWAvuKM1WfTOPbD6jFbuoec0GH2BTXLGF2V8Ad3uBMfO3moTy1HCXoWLHvk0ZuuaC0Yu+XmE1LyU6dBKr2BhkqEY10Tg4ZXT9VPhrlcvJMlMwOOtRRYU3Umfya4mqxT9p+Zme23MbVNmT7cXa3ExIEMnndQg+lfJDmj8vl7gxECTmwbsmd0YuwTE3+0pq24M7s5Gs5R+4RVPSNTh29+2HOmHvbnwk2g8DXh7ztZFUKuh+195L55kJUtj+JfGHFaL388TZnlau3mnR2zSO2LOocOE5sb23pBcyxNU+uOg8bi1phQ==; Original-Received: from [2601:8:b200:217:863a:4bff:fec8:e538] by dancol.org with esmtpsa (TLS1.0:DHE_RSA_CAMELLIA_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1W38lh-0002ck-3r; Tue, 14 Jan 2014 10:31:17 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168379 Archived-At: On 01/14/2014 10:06 AM, Jan Djärv wrote: > 14 jan 2014 kl. 18:56 skrev Stefan Monnier : > >>> The most concrete objection is the case of inheriting faces Yidong brought >>> up in another mail, which indeed is a real problem. >> >> Can someone clarify the problem? > > The region face defines :distant-foreground. A face that inherits > region can not override that attribute so that is undefined, it can only > be overridden to another color. > >> Is there an alternative suggestion which solves the original problem >> while at the same time fixing this one? > > Yidong hinted at a fix, i.e. let nil be a valid value, like for > :stipple. The argument against was that :distant-foreground would > have nil as a valid value, but :foreground does not, i.e. they do not > have the same values. The authors of the alternate implementations > must answer for their cases. My proposal does this and more. We should use it instead of the current :distant-foreground code regardless of the default policy we choose to use with it.