From: martin rudalics <rudalics@gmx.at>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: "16013@debbugs.gnu.org" <16013@debbugs.gnu.org>
Subject: bug#16013: 24.3.50; Rows in height is interpreted as pixels.
Date: Tue, 14 Jan 2014 19:10:24 +0100 [thread overview]
Message-ID: <52D57D90.3070306@gmx.at> (raw)
In-Reply-To: <EBE00F3E-DB92-40DE-A48B-67B0524FBAAF@swipnet.se>
> GNUStep has some bugs w.r.t. the tool bar, so the values for GNUStep is as good as it gets.
As for the rest the main problem is this part in x_figure_window_size:
/* This used to be done _before_ calling x_figure_window_size, but
since the height is reset here, this was really a no-op. I
assume that moving it here does what Gerd intended (although he
no longer can remember what that was... ++KFS, 2003-03-25. */
/* Add the tool-bar height to the initial frame height so that the
user gets a text display area of the size he specified with -g or
via .Xdefaults. Later changes of the tool-bar height don't
change the frame size. This is done so that users can create
tall Emacs frames without having to guess how tall the tool-bar
will get. */
if (toolbar_p && FRAME_TOOL_BAR_HEIGHT (f))
{
int margin, relief, bar_height;
relief = (tool_bar_button_relief >= 0
? tool_bar_button_relief
: DEFAULT_TOOL_BAR_BUTTON_RELIEF);
if (RANGED_INTEGERP (1, Vtool_bar_button_margin, INT_MAX))
margin = XFASTINT (Vtool_bar_button_margin);
else if (CONSP (Vtool_bar_button_margin)
&& RANGED_INTEGERP (1, XCDR (Vtool_bar_button_margin), INT_MAX))
margin = XFASTINT (XCDR (Vtool_bar_button_margin));
else
margin = 0;
/* PXW: We should be able to not round here. */
bar_height = DEFAULT_TOOL_BAR_IMAGE_HEIGHT + 2 * margin + 2 * relief;
FRAME_LINES (f) += (bar_height + FRAME_LINE_HEIGHT (f) - 1) / FRAME_LINE_HEIGHT (f);
}
If I define it out, the sizes of the first and subsequent frames are
equal on Lucid. IIUC x_figure_window_size is not called when changing
fonts or default heights.
martin
next prev parent reply other threads:[~2014-01-14 18:10 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-30 13:08 bug#16013: 24.3.50; Rows in height is interpreted as pixels Jan Djärv
2013-11-30 15:00 ` martin rudalics
2013-11-30 18:52 ` Jan Djärv
2013-12-01 9:44 ` martin rudalics
2013-12-01 10:01 ` Jan Djärv
2013-12-01 11:24 ` martin rudalics
2013-12-01 12:02 ` Jan Djärv
2013-12-02 18:15 ` martin rudalics
2013-12-02 22:03 ` Stephen Berman
2013-12-03 7:56 ` martin rudalics
2013-12-03 9:13 ` Stephen Berman
2013-12-03 18:34 ` martin rudalics
2013-12-03 20:02 ` Stephen Berman
2013-12-03 7:53 ` Jan Djärv
2013-12-03 7:58 ` martin rudalics
2013-12-03 16:30 ` Jan Djärv
2013-12-03 18:34 ` martin rudalics
2013-12-03 19:30 ` Jan Djärv
2013-12-03 19:45 ` Jan Djärv
2013-12-04 18:06 ` martin rudalics
2013-12-07 17:53 ` Jan Djärv
2013-12-07 18:09 ` martin rudalics
2013-12-09 18:26 ` martin rudalics
2014-01-11 14:01 ` martin rudalics
2014-01-11 17:46 ` Jan Djärv
2014-01-12 9:54 ` martin rudalics
2014-01-12 11:13 ` Jan Djärv
2014-01-12 11:46 ` martin rudalics
2014-01-12 20:25 ` Stefan Monnier
2014-01-12 22:21 ` Jan Djärv
2014-01-14 17:30 ` Jan Djärv
2014-01-14 18:10 ` martin rudalics [this message]
2014-01-16 10:03 ` martin rudalics
2014-01-16 10:14 ` martin rudalics
2014-01-18 11:30 ` Jan Djärv
2014-01-18 12:07 ` martin rudalics
2014-01-29 10:14 ` martin rudalics
2020-09-09 13:07 ` Lars Ingebrigtsen
2020-09-09 14:46 ` Eli Zaretskii
2020-09-10 12:40 ` Lars Ingebrigtsen
2013-12-04 18:06 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D57D90.3070306@gmx.at \
--to=rudalics@gmx.at \
--cc=16013@debbugs.gnu.org \
--cc=jan.h.d@swipnet.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.