From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#16430: 24.3.50; When fullscreen is triggered from the window manager, I can't resize window (via M-x org-export RET) Date: Tue, 14 Jan 2014 08:47:58 +0100 Message-ID: <52D4EBAE.2060903@gmx.at> References: <87mwj0glf4.fsf@bzg.ath.cx> <52D427EA.5090609@gmx.at> <87txd7g0ew.fsf@bzg.ath.cx> <52D43FEA.7010602@gmx.at> <87y52jy52o.fsf@bzg.ath.cx> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1389685757 11526 80.91.229.3 (14 Jan 2014 07:49:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 14 Jan 2014 07:49:17 +0000 (UTC) Cc: 16430@debbugs.gnu.org To: Bastien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 14 08:49:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W2ykR-00074W-Tv for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Jan 2014 08:49:20 +0100 Original-Received: from localhost ([::1]:46927 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2ykR-0007QI-Il for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Jan 2014 02:49:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2ykI-0007QB-4z for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2014 02:49:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2ykA-0003ta-Rb for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2014 02:49:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35669) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2ykA-0003tU-OQ for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2014 02:49:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W2ykA-0003ie-4X for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2014 02:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Jan 2014 07:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16430 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16430-submit@debbugs.gnu.org id=B16430.138968569114192 (code B ref 16430); Tue, 14 Jan 2014 07:49:02 +0000 Original-Received: (at 16430) by debbugs.gnu.org; 14 Jan 2014 07:48:11 +0000 Original-Received: from localhost ([127.0.0.1]:49685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2yjK-0003gp-AE for submit@debbugs.gnu.org; Tue, 14 Jan 2014 02:48:10 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:55937) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2yjH-0003gd-BN for 16430@debbugs.gnu.org; Tue, 14 Jan 2014 02:48:08 -0500 Original-Received: from [62.47.50.150] ([62.47.50.150]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0LraSn-1VM6sF16ej-013M22 for <16430@debbugs.gnu.org>; Tue, 14 Jan 2014 08:48:06 +0100 In-Reply-To: <87y52jy52o.fsf@bzg.ath.cx> X-Provags-ID: V03:K0:VYNWSq/Kdn88vhZNU1vjmFM8HryK6RPqMRup8Z9Q0RiszonNM9n L/dDGInIRFBtycO56nRMjy0z+9a8mqM2Vv5bzGWp+9YERSfoMgxbyaMQA/cgn02Yhyeylml 3kPm8gYVl3tK4KZByiWildtxHzOi4+JgNUvoyXwM/6JA7slmfQlvzRcJvP6hdqzAOeD4UHQ VRwMiJblfvniJv+U5pa4g== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:83443 Archived-At: > 2 windows of equal height. > >> Can you trigger it from >> such a configuration by simply doing M-x fit-window-to-buffer RET? > > Yes, from last emacs -Q, even outside Org Export, you need two windows > and M-x fit-window-to-buffer RET will fail sometimes. But I can't > provide a reproducible case for now. This hints at the org buffer having some special character heights in it. > What happens is that, when `window--resizable-p' is called with the > pixelwise parameter set to `t' (from within `window-resize'), then > the delta (as pixel height) is too high Can you tell me what delta is in both fullscreen versions? > and `window--resizable-p' > returns nil -- and window-resize an error. Apparently `window-resize-no-error' calls `window--resizable-p' with PIXELWISE nil yielding t while `window-resize' calls it with PIXELWISE t yielding nil. So rewriting `window-resize-no-error' as (defun window-resize-no-error (window delta &optional horizontal ignore pixelwise) "Resize WINDOW vertically if it is resizable by DELTA lines. This function is like `window-resize' but does not signal an error when WINDOW cannot be resized. For the meaning of the optional arguments see the documentation of `window-resize'. Optional argument PIXELWISE non-nil means interpret DELTA as pixels." (unless pixelwise (setq delta (if horizontal (* delta (frame-char-width (window-frame window))) (* delta (frame-char-height (window-frame window)))))) (when (window--resizable-p window delta horizontal ignore nil nil nil t) (window-resize window delta horizontal ignore t))) should fix it. Maybe I should just wrap this into a `condition-case' instead of doing my own checking. BTW what do (frame-pixel-height) and (frame-height) respectively give in the two fullscreen versions? martin