From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.devel Subject: Re: Tree sitter support for C-like languages Date: Sun, 13 Nov 2022 14:37:23 +0100 Message-ID: <52D24B27-6B0F-492B-94E7-2F67696CEC8E@thornhill.no> References: <87tu36em9t.fsf@thornhill.no> <45FD2F78-F15B-488B-9348-A8E298D8AD35@gmail.com> <87v8nmyqqp.fsf@thornhill.no> <834jv4nz2g.fsf@gnu.org> <871qq8hsj1.fsf@thornhill.no> <83iljklzmo.fsf@gnu.org> <87v8nkgcqj.fsf@thornhill.no> <87sfiogcbm.fsf@thornhill.no> <83pmdrkyj7.fsf@gnu.org> <87v8njw5th.fsf@thornhill.no> <83leofkwjm.fsf@gnu.org> <963E740B-B9BA-49E3-A64E-501394DFE41A@thornhill.no> <83h6z3ko8l.fsf@gnu.org> <87r0y7nh21.fsf@thornhill.no> <83fsenknnl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40483"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, emacs-devel@gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 13 14:39:20 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ouDCi-000AKr-6I for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Nov 2022 14:39:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouDC2-0002pn-UY; Sun, 13 Nov 2022 08:38:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouDC1-0002pc-Km for emacs-devel@gnu.org; Sun, 13 Nov 2022 08:38:37 -0500 Original-Received: from out0.migadu.com ([94.23.1.103]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouDBy-0005uP-1L; Sun, 13 Nov 2022 08:38:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1668346711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QojvuPvqv6m2OcNk7S/Hu0w6Fszw9UNOhuZFDqJgc4Q=; b=iPugONSO5/4JfZ/+AVwQmqgMx97mABAPctVev2LWUFQ9WA4f6dw6TJI/WWgHxy5DJx81Th SyBdL6s12Ji6VsCAjsp09vTtJM46dbQOfpjHAPivxiD4UWzOu0F/eCZF9CWCydqr+oeJvK yi8njXsSz0qruCy84zB8QA6WXCS1iOcR6RzHOyy7EHttg20ODlnEOb7+RJ7W9ylp9Zmqm6 yDLgayzoUcnMKqkvCiPs+xfi9ZwcQxlDFINckLTNnlunB1/5VJzus+gtpaEEyjvEP+Nlhy UGvULZTK7P+MLnaQjnp+zOE1JSIsXCLh3zIIQihGyOfq3JkxjSQ7F9rSCqFjmw== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: <83fsenknnl.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=94.23.1.103; envelope-from=theo@thornhill.no; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299722 Archived-At: On 13 November 2022 14:08:14 CET, Eli Zaretskii wrote: >> From: Theodor Thornhill >> Cc: casouri@gmail=2Ecom, emacs-devel@gnu=2Eorg, monnier@iro=2Eumontreal= =2Eca >> Date: Sun, 13 Nov 2022 14:02:30 +0100 >>=20 >> Eli Zaretskii writes: >>=20 >> >> Date: Sun, 13 Nov 2022 11:13:24 +0100 >> >> From: Theodor Thornhill >> >> CC: casouri@gmail=2Ecom, emacs-devel@gnu=2Eorg, monnier@iro=2Eumontr= eal=2Eca >> >>=20 >> >> >> I think the best solution is just to remove the >> >> >>=20 >> >> >> ``` >> >> >> :language mode >> >> >> :override t >> >> >> :feature 'error >> >> >> '((ERROR) @font-lock-warning-face) >> >> >> ``` >> >> > >> >> >What are the downsides of removing this? what will we lose? >> >> > >> >>=20 >> >> Absolutely nothing=2E Only the yellow color=2E >> > >> > Which yellow color? >> > >> > And if we lose nothing, why was this in the code to begin with? what >> > was the thought behind using it? >>=20 >> The warning face=2E My thinking was merely that identifying syntax err= ors >> could be useful, but I now believe this causes more noise and confusion >> rather than being a helpful tool=2E > >I'm not sure I agree=2E Having incomplete code show in a distinct color >could be a nice feature, at least as an option=2E The problem is that >the warning face doesn't go away when the code is completed, but I >think this is a separate and different problem=2E > >> So there's no need to use it=2E These error-nodes can be seen with >> 'treesit-inspect-mode' for those interested anyways=2E > >The inspect nod is for debugging TS-backed modes, not for editing >program source=2E So it is not relevant to what bothers me=2E > >I think we should fix the problem with the warning face staying put, >and then revisit the usefulness of the warning face=2E Sure! Yuan - do you have any pointers as to where I should look? Otherwise I'll = just start reading somewhere and see if any clues appear=2E Anyway - I'll also follow-up with another patch addressing some inconsiste= ncies between the modes later today=2E Theo