From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#16351: 24.3.50; `balance-windows' has no effect after (menu-bar-mode -1) Date: Mon, 06 Jan 2014 18:46:31 +0100 Message-ID: <52CAEBF7.4040805@gmx.at> References: <87sit2y2ck.fsf@pusto.de> <52C98CF5.1050206@gmx.at> <871u0mghzz.fsf@pusto.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1389030442 26771 80.91.229.3 (6 Jan 2014 17:47:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 6 Jan 2014 17:47:22 +0000 (UTC) Cc: 16351@debbugs.gnu.org To: Eduard Wiebe Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 06 18:47:26 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W0EGr-0003Jr-78 for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Jan 2014 18:47:25 +0100 Original-Received: from localhost ([::1]:36581 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0EGq-0000l9-T8 for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Jan 2014 12:47:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0EGf-0000YW-Qh for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2014 12:47:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0EGV-0000Kp-DU for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2014 12:47:13 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0EGV-0000Ki-A3 for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2014 12:47:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W0EGU-00069v-Lj for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2014 12:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jan 2014 17:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16351 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16351-submit@debbugs.gnu.org id=B16351.138903040723650 (code B ref 16351); Mon, 06 Jan 2014 17:47:02 +0000 Original-Received: (at 16351) by debbugs.gnu.org; 6 Jan 2014 17:46:47 +0000 Original-Received: from localhost ([127.0.0.1]:38879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0EGE-00069I-HG for submit@debbugs.gnu.org; Mon, 06 Jan 2014 12:46:46 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:55780) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0EGA-000696-5q for 16351@debbugs.gnu.org; Mon, 06 Jan 2014 12:46:43 -0500 Original-Received: from [62.47.50.117] ([62.47.50.117]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MKt5A-1W0EG81QRM-00010O for <16351@debbugs.gnu.org>; Mon, 06 Jan 2014 18:46:40 +0100 In-Reply-To: <871u0mghzz.fsf@pusto.de> X-Provags-ID: V03:K0:z7ApaUxTv4QKgqQR7IL8cF9KldAxOES8E+gdsdiyGVYocOtWWgM NFQxoQTN4MpdSmW49h6xBD6bGNkKSbQh3pRGn3VUEdJ/iAMaokh943pM7YjBAvA4bXzg6lt qx+VoS01csavpjNmFTayPydyful8q5pGknkV7tmDQ7F2TCvGXBGTogfUDzkFXCZdDE2nKlF pdW60dLEwBLLWhODWF1lA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:83067 Archived-At: > Hmm, it seems that this is a issue of my current window manager. > With good old twm i can't reproduce that, too. This shouldn't be an issue of the window manager. Otherwise, we would have a very nasty bug. So if you still can reproduce the bug please proceed as follows: `balance-windows' has this code ;; Balance vertically. (window--resize-reset (window-frame window)) (balance-windows-1 window) (when (window--resize-apply-p frame) (window-resize-apply frame) (window--pixel-to-total frame) (run-window-configuration-change-hook frame)) First change this code to ;; Balance vertically. (window--resize-reset (window-frame window)) (balance-windows-1 window) (when (window--resize-apply-p frame) (unless (window-resize-apply frame) (ding)) (window--pixel-to-total frame) (run-window-configuration-change-hook frame)) If Emacs now "dings" we know that the values written by `balance-windows-1' are wrong. In this case replace the code by ;; Balance vertically. (window--resize-reset (window-frame window)) (balance-windows-1 window) (when (window--resize-apply-p frame) (unless (window-resize-apply frame) (message "%s" (list (cons (window-pixel-height) (window-new-pixel)) (cons (window-pixel-height (window-in-direction 'below)) (window-new-pixel (window-in-direction 'below))) (cons (window-pixel-height (window-parent)) (window-new-pixel (window-parent)))))) (window--pixel-to-total frame) (run-window-configuration-change-hook frame)) invoke C-x + from the _upper_ window and post the value written by `message' here (just copy it from the buffer *Messages*). Thanks, martin