From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#16182: Acknowledgement (24.3.50; ruby-mode: Indentation style of multiline literals with hanging open paren inside other parens) Date: Fri, 20 Dec 2013 13:57:17 +0200 Message-ID: <52B4309D.8060502@yandex.ru> References: <874n66byoo.fsf@yandex.ru> <52B11F12.4070109@yandex.ru> <490C2BFA3C624DB6AB057CD2AA393D9C@gmail.com> <87txe5v4ol.fsf@yandex.ru> <1E72CA8B046B46A6B320EBB9A71FF8CA@gmail.com> <395424D4599947EBA14047DBA9440BB1@gmail.com> <52B329C1.9050602@yandex.ru> <52B3D3E6.8060409@yandex.ru> <1174B6D834D54E1C83E139525AB3C6C3@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1387540697 11833 80.91.229.3 (20 Dec 2013 11:58:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Dec 2013 11:58:17 +0000 (UTC) Cc: Steve Purcell , 16182@debbugs.gnu.org, Adam Doppelt , Adam Sokolnicki To: Bozhidar Batsov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 20 12:58:22 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vtyij-0004yD-6b for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Dec 2013 12:58:21 +0100 Original-Received: from localhost ([::1]:49069 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vtyii-0004nF-Lb for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Dec 2013 06:58:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtyiY-0004fB-LQ for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2013 06:58:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtyiR-0006bI-BK for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2013 06:58:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45611) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtyiR-0006bC-6f for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2013 06:58:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VtyiQ-0005gh-Do for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2013 06:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Dec 2013 11:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16182 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16182-submit@debbugs.gnu.org id=B16182.138754064821801 (code B ref 16182); Fri, 20 Dec 2013 11:58:02 +0000 Original-Received: (at 16182) by debbugs.gnu.org; 20 Dec 2013 11:57:28 +0000 Original-Received: from localhost ([127.0.0.1]:59630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vtyhr-0005fX-7T for submit@debbugs.gnu.org; Fri, 20 Dec 2013 06:57:27 -0500 Original-Received: from mail-ee0-f44.google.com ([74.125.83.44]:37221) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vtyhm-0005fI-I1 for 16182@debbugs.gnu.org; Fri, 20 Dec 2013 06:57:23 -0500 Original-Received: by mail-ee0-f44.google.com with SMTP id b57so1017103eek.3 for <16182@debbugs.gnu.org>; Fri, 20 Dec 2013 03:57:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=r5UehGUBzoRm2uHm4qctHc2O2gDP6c+1XeoxUf8ZCgk=; b=xCwROAul8g2mYW/272FL+u0H+Mn6waU8Kyk8ZtPlwwG4NdhxFudlbGjLM2Co4jHSOM 7z98oXqek+YWJ5tcbAGkpOy1hRaXocN4RNHBPWL02vdtLRcV0GrhZMywuDe7AkpZ8nvb 2UwdwN+KZFukkPXh8EhQyEDNtw64LS4mJkHjqrbtHqFlvVyHZ+a3FpP2nXBbwoTDG4NK 0NhsQpHeYXGDdyijRMO3WLBZssta33YGrKu8MDZWKBFmCM/oX8Ac2vRCluRisNWKVfd6 UGldTiCxwGHHlpo01YaML6/a85iN2YU86M4SaeEiW5+kVIhJtvcF5DB6dKfGMuAr2Wun UonQ== X-Received: by 10.14.37.131 with SMTP id y3mr5348573eea.1.1387540641550; Fri, 20 Dec 2013 03:57:21 -0800 (PST) Original-Received: from [192.168.10.2] (93-2-98.netrun.cytanet.com.cy. [93.109.2.98]) by mx.google.com with ESMTPSA id o1sm17919955eea.10.2013.12.20.03.57.19 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 20 Dec 2013 03:57:20 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 In-Reply-To: <1174B6D834D54E1C83E139525AB3C6C3@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82280 Archived-At: On 20.12.2013 11:51, Bozhidar Batsov wrote: > Just a small nitpick - everything that returns a value is actually an > expression, not a statement. It can be both (see "expression statement"). This way it's not ambiguous, because I'm really aligning to the statement: the containing expression, which follows the bob or an [implicit] semicolon. In Rubocop, you've chosen to align to just the parent expression. Maybe we should find a realistic example where one would be different from the other. > Maybe `ruby-align-to-expr-keywords’ would be a more appropriate name for > the option. I was thinking rather of `ruby-align-to-statement'. A non-functional change that may be easier to pronounce. > Btw, I noticed this in the indent examples: > > zoo > .lose( > q, p) > > Shouldn’t it be: > > zoo > .lose( > q, p) Maybe, but that's harder to do. Basically, we'd want to keep the additional indentation when and only when the parent token (.), or any one of its siblings (in case of a chained method call) are at indentation. Checking if the parent is at indentation is easy, but finding its siblings - not so much.